Closed Bug 779754 Opened 11 years ago Closed 11 years ago

Intermittent test_destinationURI_annotation.xul | file destination was set correctly | file name was set correctly

Categories

(Toolkit :: Downloads API, defect)

Product:
Toolkit
Component:
Downloads API
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: emorley, Assigned: Felipe)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Patch
1.36 KB, patch
mconley
: review+
Details | Diff | Splinter Review 
Rev4 MacOSX Lion 10.7 mozilla-inbound debug test mochitest-other on 2012-08-01 21:13:17 PDT for push 4141cfa13685

slave: talos-r4-lion-011

https://tbpl.mozilla.org/php/getParsedLog.php?id=14058239&tree=Mozilla-Inbound

{
28631 INFO TEST-PASS | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | file was downloaded - http://mochi.test:8888/chrome/toolkit/mozapps/downloads/tests/chrome/unknownContentType_dialog_layout_data.pif should equal http://mochi.test:8888/chrome/toolkit/mozapps/downloads/tests/chrome/unknownContentType_dialog_layout_data.pif
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: No outer window available!: file ../../../dom/base/nsGlobalWindow.cpp, line 9085
WARNING: NS_ENSURE_TRUE(mTextInputHandler) failed: file ../../../widget/cocoa/nsChildView.mm, line 4087
28632 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | file destination was set correctly
28633 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/toolkit/mozapps/downloads/tests/chrome/test_destinationURI_annotation.xul | file name was set correctly
}
Felipe, any ideas about this?
Ed, do you know if this `No outer window available` shows up often elsewhere, or is it an important clue here?

I don't know of recent changes to this functionality that could have caused the test to start failing
There is bug 782674 and bug 630242 (and I've seen it in various logs); whether it is significant in this case I don't know, sorry.
Whiteboard: [orange]
Felipe, once you're back please may you take a look at this?

At the moment, the failure rate of this test is high enough that it will be one of the ones disabled for too many intermittent failures in the near future.

Cheers :-)
Flags: needinfo?(felipc)
working on it
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Flags: needinfo?(felipc)
Attached patch Patch — — Splinter Review 
The test fails when the file it's trying to download already exists in the downloads folder, causing the check for the filename match to fail as it gets a different destination name.

This seems to only happen on Mac from time to time. This test properly removes the file at the end, so it could be that another test is leaving the file there by accident, or it's from a previous run where something else went wrong.
Since other tests use this file, I don't think it's necessary to investigate what is leaving it in the downloads folder, as this test will now check for the file existence and remove it before starting if necessary.
Attachment #702316 - Flags: review?(mconley)
Thank you for looking at this :-)
Comment on attachment 702316 [details] [diff] [review]
Patch

Review of attachment 702316 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks Felipe!
Attachment #702316 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/6f0e2f99e701
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.