Cannot connect to irc.mozilla.org if there are auto-joined channels defined

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: clokep)

Tracking

15 Branch
Thunderbird 16.0
x86
Windows 7

Thunderbird Tracking Flags

(thunderbird15+ fixed, thunderbird16+ fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

STR:

1)  Create an IRC account connecting to irc.mozilla.org, and add an auto-joined channel, like #maildev.
2)  Try to connect the account

What happens?

The "Connecting" account activity indicator just keeps spinning in the "Instant messaging status" window, and I get the following errors in the error console:

Timestamp: 02/08/2012 9:37:03 AM
Error: Error running command 001 with handler RFC 2812:
{"rawMessage":":concrete.mozilla.org 001 mconleyTB :Welcome to the Mozilla IRC Network mconleyTB!Thunderbir@66.207.208.98","command":"001","params":["mconleyTB","Welcome to the Mozilla IRC Network mconleyTB!Thunderbir@66.207.208.98"],"servername":"concrete.mozilla.org"}
Source Code:
irc

Timestamp: 02/08/2012 9:37:03 AM
Error: [Exception... "'[JavaScript Error: "channel is not defined" {file: "resource:///components/irc.js" line: 901}]' when calling method: [prplIAccount::joinChat]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: resource:///components/imAccounts.js :: <TOP_LEVEL> :: line 658"  data: yes]
Source File: resource:///modules/ircHandlers.jsm
Line: 102

What's expected?

I should connect.


So far, I'm only seeing this in TB 15 beta. I'll try Earlybird next.
This problem affects TB 15 and TB 16.

Daily does not appear to be affected.
tracking-thunderbird15: --- → ?
tracking-thunderbird16: --- → ?
(Assignee)

Comment 2

5 years ago
So it looks like https://hg.mozilla.org/releases/comm-beta/rev/7b51c0455855 (https://hg.mozilla.org/comm-central/rev/f0160c7f11c9) actually depending on a previous landing (https://hg.mozilla.org/comm-central/rev/f03b55eda4ce), which did NOT land on comm-beta.

I'm spinning up a patch now.
(Assignee)

Comment 3

5 years ago
Created attachment 648338 [details] [diff] [review]
Patch v1 (untested)

This is untested: I don't have comm-central/beta installed or the source available or a way to build it currently. The fix is fairly trivial though.
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #648338 - Flags: review?(mconley)
Comment on attachment 648338 [details] [diff] [review]
Patch v1 (untested)

I can confirm that this fixes the bug.

Your patch, however, has Windows style line endings. I'll upload a fixed patch.
Attachment #648338 - Flags: review?(mconley) → review+
Created attachment 648383 [details] [diff] [review]
Patch v2 (by clokep)

Patch with better line endings.
Attachment #648338 - Attachment is obsolete: true
Attachment #648383 - Flags: review+
Attachment #648383 - Flags: approval-comm-beta?
Attachment #648383 - Flags: approval-comm-aurora?
tracking-thunderbird15: ? → +
tracking-thunderbird16: ? → +
Attachment #648383 - Flags: approval-comm-beta?
Attachment #648383 - Flags: approval-comm-beta+
Attachment #648383 - Flags: approval-comm-aurora?
Attachment #648383 - Flags: approval-comm-aurora+
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/ccec873292af
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/d30295ff2691
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.