msconfig.vs2010 contains POSIX-style paths

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: sid0, Assigned: sid0)

Tracking

Trunk
mozilla17
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

https://mxr.mozilla.org/mozilla-central/source/build/win32/mozconfig.vs2010?raw=1&ctype=

This breaks pymake. Horribly.
(Assignee)

Updated

5 years ago
Blocks: 593585
The only good solution I can think of is to do export FOO=`choose_right_path.xy .....` or some such. Not sure if others would agree with me regarding that complexity though.
(Assignee)

Comment 2

5 years ago
Created attachment 648521 [details] [diff] [review]
possible patch

Another issue cropped up: backslashes in PATH etc weren't escaped properly. I fixed that too.

I'm running a pymake build on my loaner build machine right now.
Attachment #648521 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

5 years ago
Created attachment 648523 [details] [diff] [review]
fixed patch

oops, missed a file.
Attachment #648521 - Attachment is obsolete: true
Attachment #648521 - Flags: review?(ted.mielczarek)
Attachment #648523 - Flags: review?(ted.mielczarek)
Comment on attachment 648523 [details] [diff] [review]
fixed patch

Review of attachment 648523 [details] [diff] [review]:
-----------------------------------------------------------------

This is horrible, but not much worse than it was previously.

::: build/autoconf/mozconfig2client-mk
@@ +31,5 @@
>    for _opt
>    do
>      # Escape shell characters, space, tab, dollar, quote, backslash,
>      # and substitute '@<word>@' with '$(<word>)'.
> +    _opt=`echo "$_opt" | sed -e 's/\([\"\\]\)/\\\\\1/g; s/@\([^@]*\)@/\$(\1)/g;'`

I have no idea how I would possibly review this, so I'm just going to trust your judgement.
Attachment #648523 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/3cc378b302c9
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3cc378b302c9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Assignee)

Comment 7

5 years ago
Ported to comm-central to fix check-sync-dirs.py failures: http://hg.mozilla.org/comm-central/rev/106fe68e2fae
You need to log in before you can comment on or make changes to this bug.