Closed Bug 779922 Opened 12 years ago Closed 12 years ago

msconfig.vs2010 contains POSIX-style paths

Categories

(Firefox Build System :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: rain1, Assigned: rain1)

References

Details

Attachments

(1 file, 1 obsolete file)

Blocks: 593585
The only good solution I can think of is to do export FOO=`choose_right_path.xy .....` or some such. Not sure if others would agree with me regarding that complexity though.
Attached patch possible patch (obsolete) — Splinter Review
Another issue cropped up: backslashes in PATH etc weren't escaped properly. I fixed that too.

I'm running a pymake build on my loaner build machine right now.
Attachment #648521 - Flags: review?(ted.mielczarek)
Attached patch fixed patchSplinter Review
oops, missed a file.
Attachment #648521 - Attachment is obsolete: true
Attachment #648521 - Flags: review?(ted.mielczarek)
Attachment #648523 - Flags: review?(ted.mielczarek)
Comment on attachment 648523 [details] [diff] [review]
fixed patch

Review of attachment 648523 [details] [diff] [review]:
-----------------------------------------------------------------

This is horrible, but not much worse than it was previously.

::: build/autoconf/mozconfig2client-mk
@@ +31,5 @@
>    for _opt
>    do
>      # Escape shell characters, space, tab, dollar, quote, backslash,
>      # and substitute '@<word>@' with '$(<word>)'.
> +    _opt=`echo "$_opt" | sed -e 's/\([\"\\]\)/\\\\\1/g; s/@\([^@]*\)@/\$(\1)/g;'`

I have no idea how I would possibly review this, so I'm just going to trust your judgement.
Attachment #648523 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/3cc378b302c9
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/3cc378b302c9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Ported to comm-central to fix check-sync-dirs.py failures: http://hg.mozilla.org/comm-central/rev/106fe68e2fae
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.