779939 - Fix up nsGlobalWindow::OpenInternal and corresponding nsWindowWatcher methods

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Justin Lebar (not reading bugmail)]

nsGlobalWindow::OpenInternal is messed up in a variety of ways.

Principally, nsGlobalWindow::ShowModalDialog must lie about some of its parameters (e.g. aDialog, aCalledNoScript) in order to get the right behavior from OpenInternal.  Then, nsWindowWatcher::OpenWindow2 must revert these lies.

There are also unused parameters (aCalleePrincipal), and general badness (taking 13 arguments, 5 of which are booleans).

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.