780146 - Various DOMClassInfo cleanup

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I've got a few patches to simplify nsDOMClassInfo a bit.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: _content

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: Inline nsDOMClassInfo::RegisterClassName

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: Don't define constructors by contract ID

There are about four score and seven ways to define a constructor, so I think this one, at least, can go.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: Inline mozilla::dom::binding::DefineConstructor

I don't see the point of having this function.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 648693 [details] [diff] [review]
Part a: _content

The reason we did this in the first place was for performance back in the day. I doubt it matters any more, and I'm guessing we don't use _content much any more.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 648693 [details] [diff] [review]
Part a: _content

Oh, but you should bump the iid for nsIDOMJSWindow.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part e: Move all standard classes resolution code into ObjectIsNativeWrapper

This code can only be reached if ObjectIsNativeWrapper was false; I think it's clearer to move it into the if.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: diff -w (part e)

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 648693 [details] [diff] [review]
Part a: _content

https://hg.mozilla.org/mozilla-central/rev/c77acb256aec

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 648694 [details] [diff] [review]
Part b: Inline nsDOMClassInfo::RegisterClassName

https://hg.mozilla.org/mozilla-central/rev/b20779389b5a

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 648696 [details] [diff] [review]
Part c: Don't define constructors by contract ID

https://hg.mozilla.org/mozilla-central/rev/0e6e404c6baf

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 649663 [details] [diff] [review]
Part e: Move all standard classes resolution code into ObjectIsNativeWrapper

https://hg.mozilla.org/mozilla-central/rev/0f96a7f073a8

Comment 13

[Frederic Bezies]

Just guessing. Could bug 781525 a side effect of these patches landing ?

Mike Hommey """thinks""" so.

Comment 14

[Masatoshi Kimura [:emk]]

(In reply to :Ms2ger from comment #9)
> Comment on attachment 648693 [details] [diff] [review]
> Part a: _content
> 
> https://hg.mozilla.org/mozilla-central/rev/c77acb256aec

window._content has disappeared because of this change.
A preceding underscore will be removed to make reserved words available as identifiers such as "char" attribute of KeyEvent (see bug 762758).

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 648693 [details] [diff] [review]
Part a: _content

https://hg.mozilla.org/integration/mozilla-inbound/rev/eac51122b5aa

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Masatoshi Kimura [:emk] from comment #14)
> (In reply to :Ms2ger from comment #9)
> > Comment on attachment 648693 [details] [diff] [review]
> > Part a: _content
> > 
> > https://hg.mozilla.org/mozilla-central/rev/c77acb256aec
> 
> window._content has disappeared because of this change.
> A preceding underscore will be removed to make reserved words available as
> identifiers such as "char" attribute of KeyEvent (see bug 762758).

So, how am I supposed to declare an attribute whose name starts with an underscore?

Comment 17

[Masatoshi Kimura [:emk]]

(In reply to :Ms2ger from comment #16)
> So, how am I supposed to declare an attribute whose name starts with an
> underscore?
It's impossible, AFAICT :(
Identifiers can't start with an underscore even before bug 762758.

Comment 18

[Masatoshi Kimura [:emk]]

WebIDL does not allow identifiers beginning with underscore either.
http://dev.w3.org/2006/webapi/WebIDL/#proddef-ArgumentNameKeyword

Comment 19

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 648697 [details] [diff] [review]
Part d: Inline mozilla::dom::binding::DefineConstructor

r=me

Comment 20

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 648697 [details] [diff] [review]
Part d: Inline mozilla::dom::binding::DefineConstructor

Landed for Gecko 18:

https://hg.mozilla.org/mozilla-central/rev/bbf6b499528a

Comment 21

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/bbf6b499528a