780191 - Form autocomplete wonkiness with Samsung Galaxy Nexus's IME spelling autocorrection

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect, P1)

Description

[Martijn Wargers (dead)]

This is with current trunk build.

Steps to reproduce:
- Go to provided url, tap on the text input, type 'b c d' and submit
- Tap on the text input again, type 'b' -> form autocomplete popup pops up
- Tap on the form autocomplete entry 'b c d'.

Expected result:
'b c d' shows up in the text input

Actual result:
' c d' shows up in the text input

Also, the caret is at the start of the text, it should be at the end of the text.
Also, when pressing backspace (after moving the caret to the end of the text), you get to see strange behavior.

Comment 1

[Chris Peterson [:cpeterson]]

I can repro with Nightly 17 and Aurora 16 on both my Galaxy Nexus and Note. When I select form autocomplete, the form text changes from "b" to ".c d" (with a period).

The problem is that the IME's spelling autocorrection gets confused when . If I disable the IME's autocorrection, then form autocomplete works correctly. We've seen problems like this where some IMEs try autocorrect the partial text inserted by form autocomplete.

Comment 2

[Chris Peterson [:cpeterson]]

^ 
The problem is that the IME's spelling autocorrection gets confused when Gecko's form autocomplete changes the form text before notifying the IME.

Comment 3

[Chris Peterson [:cpeterson]]

This bug is fallout from bug 764193. Fortunately, I already have a patch with the fix. I had just forgotten the STR for the bug fixed by the patch (until now). <:)

Comment 4

[Chris Peterson [:cpeterson]]

Attachment: commit-composition-before-autocomplete.patch

Commit composition string before sending autocomplete text event.

XUL Fennec had the same problem, which Makoto fixed in bug 632744.

Comment 5

[Chris Peterson [:cpeterson]]

Green tryserver run:
https://tbpl.mozilla.org/?tree=Try&rev=6db4694cc2bf

Comment 6

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ded8626838cb

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ded8626838cb

Comment 8

[Chris Peterson [:cpeterson]]

Comment on attachment 649453 [details] [diff] [review]
commit-composition-before-autocomplete.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Enabling form autocomplete popup in bug 764193
User impact if declined: Form autocomplete is utterly broken in its current state for some IMEs on popular phones like Galaxy Nexus!
Testing completed (on m-c, etc.): This is an old bug fix from XUL Fennec uplifted to m-c.
Risk to taking this patch (and alternatives if risky): Medium risk because the change might confuse third-party IMEs, *BUT* the code is utterly broken in its current state for some IMEs on popular phones like Galaxy Nexus!
String or UUID changes made by this patch: N/A

This patch does not need to be uplifted to Beta 15 because form autocomplete is not enabled in that branch.

Comment 9

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/56170d1c2eb3

Comment 10

[Martijn Wargers (dead)]

Ok, this bug seems fixed now, but the part in comment 0 where I'm mentioning that I'm seeing strange behavior in combination with the backspace key is not fixed, so I filed bug 783067 for that.

Comment 11

[Adrian Tamas (:AdrianT)]

The issue described in bug 783067 is still reproducible but I am unable to reproduce the scenario described in comment 0 on:

Firefox Mobile 16.0b5 / Aurora 17.0a2 2012-09-26
Samsung Galaxy Nexus (Android 4.1.1)

Marking as verified on Firefox Mobile 16 and 17