78028 - RFE: Personal Toolbar Context Menu should have "Open in new Window"

Status: VERIFIED DUPLICATE of bug 102311

(SeaMonkey :: General, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

It would be nice if the Context menu of the personal toolbar items had an Option
"Open Link in new Window", just like normal links.

Comment 1

[Jesse Ruderman]

*** Bug 84941 has been marked as a duplicate of this bug. ***

Comment 2

[mdimitrio]

Agreed.

Comment 3

[Alex Bishop]

See also bug 59132.

Comment 4

[Tim Powell]

*** Bug 100304 has been marked as a duplicate of this bug. ***

Comment 5

[jlarsen]

Ok, the option appears to be there now, but it doesn't work. We you really
shouldn't land something like that into the trunk before you have it working? :)

Comment 6

[jlarsen]

side note, the sidebar bookmarks still don't have this option. Or is that a
seperate bug?

Comment 7

[Gervase Markham [:gerv]]

What needs doing here is finding the file with that particular string in, seeing
who checked it in and when, and seeing what else got checked in at the same
time. You can then perhaps see what the code is that might be broken, and use
dump() to work out what's going on and how to fix it.

Gerv

Comment 8

[Chris Abbey]

The string comes from
xpfe/components/bookmarks/resources/locale/en-US/bookmark.properties where it is
defined as cmd_openfolderinnewwindow. It is used in both
xpfe/components/bookmarks/resources/bookmarksTree.js and
xpfe/browser/resources/content/personalToolbar.js in both cases cvs blame says
ben put them in there long before johnlar noticed their presence. I've tried to
put dumps in and figure out which one is responsible for which menu, but I'm
seeing *both* get fired when I right click on either one.... I've tried setting
one, then the other to be false for "supportsCommand", in both cases the entry
still shows up.

Having said that, in the sidebar it does properly showup and function if you
click on a folder, so bookmarks still need open in new window, and both need
open in new tab.

oh, and I suggest platform/os should be all/all since this is hardly win2k related.

Comment 9

[Chris Lyon]

Should this bug be marked as a dupe of the more specific Bug 102311?

Comment 10

[Jeremy M. Dolan]

FIXED over in 102311. Still no open in new tab, though :(.

*** This bug has been marked as a duplicate of 102311 ***

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

verifying