Closed
Bug 780421
Opened 13 years ago
Closed 13 years ago
[Error 193] %1 is not a valid Win32 application
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: drexler, Assigned: rain1)
References
Details
Attachments
(2 files)
59.35 KB,
text/plain
|
Details | |
2.98 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Drexler@DREXLER-PC /c/Repos/MozRepo/src
$ hg tip
changeset: 101439:0a17cde2a4b6
tag: tip
parent: 101355:d75ca2cb6a2c
parent: 101438:c801b99d726f
user: Ed Morley <emorley@mozilla.com>
date: Sat Aug 04 19:10:28 2012 +0100
summary: Merge last PGO-green changeset of mozilla-inbound to mozilla-central
This revision causes build failures. It seems to be related to changes made in Bug 774032
Assignee | ||
Comment 1•13 years ago
|
||
A missing $(PYTHON) somewhere?
Assignee | ||
Comment 2•13 years ago
|
||
Are you using Pymake, Andrew?
Assignee | ||
Comment 3•13 years ago
|
||
Also, a log of the build failure would be good.
Reporter | ||
Comment 4•13 years ago
|
||
(In reply to Siddharth Agarwal [:sid0] from comment #2)
> Are you using Pymake, Andrew?
Yes. Attached is the build log.
Assignee | ||
Comment 5•13 years ago
|
||
Comment on attachment 649037 [details]
build log
Looks like Pymake's trying to execute config.status at https://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1164. Since Pymake tries its level best not to go through sh for recipes, it's failing there.
If a shell script is executed from a Makefile, it should have the shell name prefixed to it. glandium?
Comment 6•13 years ago
|
||
Might not help, but I'm experiencing the same problem ... WIN7 ... MStudio 2010 ... just pulled from mozilla-central prior to the issue
Assignee | ||
Comment 7•13 years ago
|
||
I believe I've covered all the places config.status is used -- trunk's still building though.
Attachment #649049 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 8•13 years ago
|
||
Pymake builds should work with this patch.
Updated•13 years ago
|
Attachment #649049 -
Flags: review?(mh+mozilla) → review+
Updated•13 years ago
|
Assignee: nobody → sagarwal
Assignee | ||
Comment 9•13 years ago
|
||
Somebody please check this in. I'm away from the computer all of today.
Assignee | ||
Updated•13 years ago
|
Attachment #649049 -
Flags: checkin?
Comment 10•13 years ago
|
||
Target Milestone: --- → mozilla17
Updated•13 years ago
|
Attachment #649049 -
Flags: checkin? → checkin+
Comment 11•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•