Last Comment Bug 780421 - [Error 193] %1 is not a valid Win32 application
: [Error 193] %1 is not a valid Win32 application
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Siddharth Agarwal [:sid0] (inactive)
:
Mentors:
Depends on:
Blocks: 593585 774032
  Show dependency treegraph
 
Reported: 2012-08-04 15:28 PDT by Andrew Quartey [:drexler]
Modified: 2012-08-05 08:49 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
build log (59.35 KB, text/plain)
2012-08-04 15:47 PDT, Andrew Quartey [:drexler]
no flags Details
possible patch (2.98 KB, patch)
2012-08-04 17:52 PDT, Siddharth Agarwal [:sid0] (inactive)
mh+mozilla: review+
mh+mozilla: checkin+
Details | Diff | Review

Description Andrew Quartey [:drexler] 2012-08-04 15:28:46 PDT
Drexler@DREXLER-PC /c/Repos/MozRepo/src
$ hg tip
changeset:   101439:0a17cde2a4b6
tag:         tip
parent:      101355:d75ca2cb6a2c
parent:      101438:c801b99d726f
user:        Ed Morley <emorley@mozilla.com>
date:        Sat Aug 04 19:10:28 2012 +0100
summary:     Merge last PGO-green changeset of mozilla-inbound to mozilla-central

This revision causes build failures. It seems to be related to changes made in Bug 774032
Comment 1 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 15:31:39 PDT
A missing $(PYTHON) somewhere?
Comment 2 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 15:32:17 PDT
Are you using Pymake, Andrew?
Comment 3 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 15:34:30 PDT
Also, a log of the build failure would be good.
Comment 4 Andrew Quartey [:drexler] 2012-08-04 15:47:02 PDT
Created attachment 649037 [details]
build log

(In reply to Siddharth Agarwal [:sid0] from comment #2)
> Are you using Pymake, Andrew?

Yes. Attached is the build log.
Comment 5 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 15:55:31 PDT
Comment on attachment 649037 [details]
build log

Looks like Pymake's trying to execute config.status at https://mxr.mozilla.org/mozilla-central/source/config/rules.mk#1164. Since Pymake tries its level best not to go through sh for recipes, it's failing there.

If a shell script is executed from a Makefile, it should have the shell name prefixed to it. glandium?
Comment 6 Mark Capella [:capella] 2012-08-04 16:06:50 PDT
Might not help, but I'm experiencing the same problem ... WIN7 ... MStudio 2010 ... just pulled from mozilla-central prior to the issue
Comment 7 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 17:52:28 PDT
Created attachment 649049 [details] [diff] [review]
possible patch

I believe I've covered all the places config.status is used -- trunk's still building though.
Comment 8 Siddharth Agarwal [:sid0] (inactive) 2012-08-04 18:27:09 PDT
Pymake builds should work with this patch.
Comment 9 Siddharth Agarwal [:sid0] (inactive) 2012-08-05 03:21:01 PDT
Somebody please check this in. I'm away from the computer all of today.
Comment 11 Ed Morley [:emorley] 2012-08-05 08:49:01 PDT
https://hg.mozilla.org/mozilla-central/rev/043cc75b3a4c

Note You need to log in before you can comment on or make changes to this bug.