780423 - Process background tabs slower when user is active

Status: RESOLVED INCOMPLETE

(Core :: General, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This patch relies on https://bugzilla.mozilla.org/attachment.cgi?id=649036
The approach is perhaps too aggressive, but I'll test it.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: tiny bit less aggressive

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Looks like the patch causes one failure on http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/test/browser_595601-restore_hidden.js
I expect that to be a test bug (some kind of racy test)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Olli Pettay [:smaug] from comment #2)
> Looks like the patch causes one failure on
> http://mxr.mozilla.org/mozilla-central/source/browser/components/
> sessionstore/test/browser_595601-restore_hidden.js
That failure is random :/

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

I was trying to investigate this but the patches from bug 779459 don't seem to apply.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Just the last patch for ESM is needed.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Actually, perhaps we should check if some refreshtimer or user has been active.

Comment 7

[(dormant account)]

(In reply to Olli Pettay [:smaug] from comment #6)
> Actually, perhaps we should check if some refreshtimer or user has been
> active.

Ie unify with logic in https://bugzilla.mozilla.org/show_bug.cgi?id=767209#c3?

Would it make sense to unthrottle background tabs only while browser is inactive?

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

well https://bugzilla.mozilla.org/show_bug.cgi?id=767209#c3 doesn't care about user interaction 

Background tabs are pretty heavily "throttled". I mainly want to decrease the probability that
refreshtimer is called when user is interacting with the browser.

Comment 9

[(dormant account)]

(In reply to Olli Pettay [:smaug] from comment #8)
> well https://bugzilla.mozilla.org/show_bug.cgi?id=767209#c3 doesn't care
> about user interaction 

"The inter-slice timer only fires if there hasn't been any painting for the last 100ms" painting is a pretty good indicator that the user is doing something.

Comment 10

[Wayne Mery (:wsmwk)]

Obsolete?

Comment 11

[Andrew McCreight [:mccr8]]

Olli, is this useful or has it been superseded by other work? Thanks.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

This doesn't seem to be useful anymore. DOM timers were tweaked for example for quantum dom.