Closed
Bug 780645
Opened 13 years ago
Closed 13 years ago
browser_595601-restore_hidden.js needs to wait for all tabs to be restored before continuing with the second test
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 17
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
Attachments
(1 file)
|
1.09 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
browser_595601-restore_hidden.js currently doesn't wait for all tabs to be restored. It proceeds when a specific number of tabs is restoring.
The two tests run in separate windows but if we start the second test before tabs from the first one finished loading, we'll sometimes not get the expected number of tabs restoring at the same time.
Thus, we'll need to wait until (isRestoring == 1) because we're notified before session store. We then should only continue using executeSoon() to let session store process the progress listener notification.
Attachment #649301 -
Flags: review?(felipc)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 649301 [details] [diff] [review]
patch v1
would it be good to add a brief comment explaining isRestoring == 1?
Attachment #649301 -
Flags: review?(felipc) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to :Felipe Gomes from comment #1)
> would it be good to add a brief comment explaining isRestoring == 1?
Of course, will do that. Thanks!
|
|
Assignee | |
Comment 3•13 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
|
Assignee | |
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 17
You need to log in
before you can comment on or make changes to this bug.
Description
•