The default bug view has changed. See this FAQ.

browser_595601-restore_hidden.js needs to wait for all tabs to be restored before continuing with the second test

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Session Restore
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 649301 [details] [diff] [review]
patch v1

browser_595601-restore_hidden.js currently doesn't wait for all tabs to be restored. It proceeds when a specific number of tabs is restoring.

The two tests run in separate windows but if we start the second test before tabs from the first one finished loading, we'll sometimes not get the expected number of tabs restoring at the same time.

Thus, we'll need to wait until (isRestoring == 1) because we're notified before session store. We then should only continue using executeSoon() to let session store process the progress listener notification.
Attachment #649301 - Flags: review?(felipc)
Comment on attachment 649301 [details] [diff] [review]
patch v1

would it be good to add a brief comment explaining isRestoring == 1?
Attachment #649301 - Flags: review?(felipc) → review+
(Assignee)

Comment 2

5 years ago
(In reply to :Felipe Gomes from comment #1)
> would it be good to add a brief comment explaining isRestoring == 1?

Of course, will do that. Thanks!
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/fba2eb0c80ab
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/fba2eb0c80ab
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.