Closed Bug 780433 Opened 7 years ago Closed 7 years ago

Update the volume control scrubber

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached image Screenshot of new icon in action (obsolete) —
Bug 681548 updated the icons for <video> controls, but it left out a new icon for the volume scrubber.

I played with a graphics editor (not MS Paint :) and came up with something that I think matches our current set of icons and can work as the volume scrubber.
Attachment #649058 - Flags: ui-review?(shorlander)
Attached image Standalone icon (obsolete) —
Attachment #649059 - Attachment is patch: false
Attachment #649059 - Attachment mime type: text/plain → image/png
Comment on attachment 649058 [details]
Screenshot of new icon in action

Looks good :) Could you please make it a little more opaque so that it stands out a little more from the volume slider background?
Attachment #649058 - Flags: ui-review?(shorlander) → ui-review-
Attached patch Patch (obsolete) — Splinter Review
I updated the icon to be opaque in the middle but I kept the translucent borders and lower shadow.

Here is a screenshot of the patch applied: http://screencast.com/t/BXiO4vCb5
Attachment #649058 - Attachment is obsolete: true
Attachment #649059 - Attachment is obsolete: true
Attachment #649960 - Flags: review?(shorlander)
Attached patch Patch option 2Splinter Review
Dolske and Blair commented that the patch attached in comment #3 didn't have enough contrast with the volume bar. This patch lightens the color of the volume bar and also tweaks the mid-shadow of the scrubber icon to compensate for the now lighter track.

This is a screenshot of this patch: http://screencast.com/t/AuQxnJJkdI
Attachment #655506 - Flags: review?(shorlander)
Attachment #655506 - Flags: review?(shorlander) → review+
Attachment #649960 - Attachment is obsolete: true
Attachment #649960 - Flags: review?(shorlander)
https://hg.mozilla.org/mozilla-central/rev/4a20b03e608d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: mozilla18 → mozilla17
You need to log in before you can comment on or make changes to this bug.