new Volume Control Scrubber seems displaced horizontally

RESOLVED FIXED in Firefox 17

Status

()

Toolkit
Themes
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: xtc4uall, Assigned: jaws)

Tracking

({regression})

17 Branch
mozilla18
regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox17+ fixed)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
See Attachment.
(Reporter)

Comment 1

5 years ago
Created attachment 656167 [details]
Screenshot showing the Issue

Arrg, hit Enter Key by Accident too early.

Reg Range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8af6a22827ec&tochange=8af2ff9c6018

likely by Bug 780433
(Reporter)

Updated

5 years ago
Blocks: 780433
Keywords: regression
(Reporter)

Updated

5 years ago
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Version: Trunk → 17 Branch
tracking-firefox17: --- → ?
Created attachment 663233 [details] [diff] [review]
Patch

Silly image, off-by-one pixels are for kids!

I also used optimized the png size.
Attachment #663233 - Flags: review?(mnoorenberghe+bmo)
Comment on attachment 663233 [details] [diff] [review]
Patch

Is there reason the subject (16x8px) of the image isn't centered in the canvas (21x10px)? i.e. why not 20x10px?  Is the point of all the transparent pixels (alpha=0) in the image to provide a bigger clip target?
Attachment #663233 - Flags: review?(mnoorenberghe+bmo)
Created attachment 663471 [details] [diff] [review]
Patch v2

No reason, I removed the extra column of pixels in this version of the patch and updated the CSS to reflect the change.

Asking dolske for review since he's a toolkit peer.
Attachment #663233 - Attachment is obsolete: true
Attachment #663471 - Flags: review?(dolske)
Comment on attachment 663471 [details] [diff] [review]
Patch v2

rs=me
Attachment #663471 - Flags: review?(dolske) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1e20611089c
Flags: in-litmus-
OS: Windows 7 → All
Hardware: x86_64 → All
Flags: in-litmus- → in-testsuite-

Comment 7

5 years ago
Agreed that we should take the visual fix on FF17, as it's affected. Tracking.
tracking-firefox17: ? → +
https://hg.mozilla.org/mozilla-central/rev/d1e20611089c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18

Updated

5 years ago
Component: Video/Audio Controls → Themes

Comment 9

5 years ago
(In reply to Ryan VanderMeulen from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/d1e20611089c

Are we comfortable with an uplift at this point?
Comment on attachment 663471 [details] [diff] [review]
Patch v2

Yeah, thanks for the reminder.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 780433
User impact if declined: awkward looking volume slider
Testing completed (on m-c, etc.): m-c for a week
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none
Attachment #663471 - Flags: approval-mozilla-aurora?
Attachment #663471 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Been on m-c for a week, low risk, approving for Aurora.
status-firefox17: --- → affected
https://hg.mozilla.org/releases/mozilla-aurora/rev/e2dd0df7f9cf
status-firefox17: affected → fixed
You need to log in before you can comment on or make changes to this bug.