Closed Bug 786420 Opened 8 years ago Closed 8 years ago
new Volume Control Scrubber seems displaced horizontally
Arrg, hit Enter Key by Accident too early. Reg Range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8af6a22827ec&tochange=8af2ff9c6018 likely by Bug 780433
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Version: Trunk → 17 Branch
Silly image, off-by-one pixels are for kids! I also used optimized the png size.
Comment on attachment 663233 [details] [diff] [review] Patch Is there reason the subject (16x8px) of the image isn't centered in the canvas (21x10px)? i.e. why not 20x10px? Is the point of all the transparent pixels (alpha=0) in the image to provide a bigger clip target?
No reason, I removed the extra column of pixels in this version of the patch and updated the CSS to reflect the change. Asking dolske for review since he's a toolkit peer.
Comment on attachment 663471 [details] [diff] [review] Patch v2 rs=me
Attachment #663471 - Flags: review?(dolske) → review+
OS: Windows 7 → All
Hardware: x86_64 → All
Flags: in-litmus- → in-testsuite-
Agreed that we should take the visual fix on FF17, as it's affected. Tracking.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(In reply to Ryan VanderMeulen from comment #8) > https://hg.mozilla.org/mozilla-central/rev/d1e20611089c Are we comfortable with an uplift at this point?
Comment on attachment 663471 [details] [diff] [review] Patch v2 Yeah, thanks for the reminder. [Approval Request Comment] Bug caused by (feature/regressing bug #): 780433 User impact if declined: awkward looking volume slider Testing completed (on m-c, etc.): m-c for a week Risk to taking this patch (and alternatives if risky): none expected String or UUID changes made by this patch: none
Attachment #663471 - Flags: approval-mozilla-aurora?
Attachment #663471 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Been on m-c for a week, low risk, approving for Aurora.
You need to log in before you can comment on or make changes to this bug.