786420 - new Volume Control Scrubber seems displaced horizontally

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[(mostly gone) XtC4UaLL [:xtc4uall]]

See Attachment.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

Attachment: Screenshot showing the Issue

Arrg, hit Enter Key by Accident too early.

Reg Range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8af6a22827ec&tochange=8af2ff9c6018

likely by Bug 780433

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Silly image, off-by-one pixels are for kids!

I also used optimized the png size.

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 663233 [details] [diff] [review]
Patch

Is there reason the subject (16x8px) of the image isn't centered in the canvas (21x10px)? i.e. why not 20x10px?  Is the point of all the transparent pixels (alpha=0) in the image to provide a bigger clip target?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

No reason, I removed the extra column of pixels in this version of the patch and updated the CSS to reflect the change.

Asking dolske for review since he's a toolkit peer.

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 663471 [details] [diff] [review]
Patch v2

rs=me

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d1e20611089c

Comment 7

[Alex Keybl [:akeybl]]

Agreed that we should take the visual fix on FF17, as it's affected. Tracking.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d1e20611089c

Comment 9

[Alex Keybl [:akeybl]]

(In reply to Ryan VanderMeulen from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/d1e20611089c

Are we comfortable with an uplift at this point?

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 663471 [details] [diff] [review]
Patch v2

Yeah, thanks for the reminder.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 780433
User impact if declined: awkward looking volume slider
Testing completed (on m-c, etc.): m-c for a week
Risk to taking this patch (and alternatives if risky): none expected
String or UUID changes made by this patch: none

Comment 11

[Lukas Blakk [:lsblakk] use ?needinfo]

Been on m-c for a week, low risk, approving for Aurora.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e2dd0df7f9cf