The default bug view has changed. See this FAQ.

Infinite repeating message "Makefile is unchanged" unless clobbered (pymake build only?)

RESOLVED FIXED in mozilla17

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

(Blocks: 1 bug)

unspecified
mozilla17
x86_64
Windows 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
I was not able to build even with bug 780421 and bug 780430 patch.
It's not infinite. It's just one for each Makefile, and is a one-time only thing. That is, after you either clobber or touch all Makefiles in the tree, it won't happen again (unless you edit a Makefile.in without modifying it, or modifying it in a way that doesn't affect its preprocessed Makefile counterpart, in which case it will only happen for that one Makefile, not all of them).
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
(Assignee)

Comment 2

5 years ago
Created attachment 649077 [details] [diff] [review]
Touch unmodified file

to satisfy pymake...
Attachment #649077 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Attachment #649077 - Flags: review?(mh+mozilla)
(Assignee)

Comment 3

5 years ago
(In reply to Mike Hommey [:glandium] from comment #1)
> It's not infinite. It's just one for each Makefile, and is a one-time only
> thing. That is, after you either clobber or touch all Makefiles in the tree,
> it won't happen again (unless you edit a Makefile.in without modifying it,
> or modifying it in a way that doesn't affect its preprocessed Makefile
> counterpart, in which case it will only happen for that one Makefile, not
> all of them).
But I observed ConfigStatus.py was called for the same one Makefile over and over.
Mmmm maybe pymake is not happy with the file not being modified by the rule supposedly modifying it, and it runs the rule again for other files (basically, all files depend on Makefile, so for each file it builds, it would try to rebuild Makefile).

I'd accept a patch that adds $(TOUCH) commands to the Makefile generation rules in config/rules.mk|js/src/config/rules.mk.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Blocks: 774032
(Assignee)

Comment 5

5 years ago
Created attachment 649083 [details] [diff] [review]
touch Makefile after invoking config.status

https://tbpl.mozilla.org/?tree=Try&rev=ba019d4354ff
Assignee: nobody → VYV03354
Attachment #649077 - Attachment is obsolete: true
Status: REOPENED → ASSIGNED
Attachment #649083 - Flags: review?(mh+mozilla)
Comment on attachment 649083 [details] [diff] [review]
touch Makefile after invoking config.status

Review of attachment 649083 [details] [diff] [review]:
-----------------------------------------------------------------

You need to do the change on the SUBMAKEFILES rule as well, and to js/src/config/rules.mk.
Attachment #649083 - Flags: review?(mh+mozilla) → review-
Comment on attachment 649083 [details] [diff] [review]
touch Makefile after invoking config.status

Review of attachment 649083 [details] [diff] [review]:
-----------------------------------------------------------------

You need to do the change on the SUBMAKEFILES rule as well, and to js/src/config/rules.mk.

::: config/rules.mk
@@ +1154,5 @@
>  
>  ifndef NO_MAKEFILE_RULE
>  Makefile: Makefile.in
>  	@$(PYTHON) $(DEPTH)/config.status -n --file=Makefile
> +	@$(TOUCH) Makefile

Also, just use $(TOUCH) $@
(Assignee)

Comment 8

5 years ago
Created attachment 649089 [details] [diff] [review]
touch Makefile after invoking config.status

(In reply to Mike Hommey [:glandium] from comment #7)
> You need to do the change on the SUBMAKEFILES rule as well, and to
> js/src/config/rules.mk.
Done.

> ::: config/rules.mk
> @@ +1154,5 @@
> >  
> >  ifndef NO_MAKEFILE_RULE
> >  Makefile: Makefile.in
> >  	@$(PYTHON) $(DEPTH)/config.status -n --file=Makefile
> > +	@$(TOUCH) Makefile
> 
> Also, just use $(TOUCH) $@
Done.
Attachment #649089 - Flags: review?(mh+mozilla)
Comment on attachment 649089 [details] [diff] [review]
touch Makefile after invoking config.status

I'll land this shortly.
Attachment #649089 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/24389ed3dd72
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/24389ed3dd72
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Updated

3 years ago
Blocks: 941904
You need to log in before you can comment on or make changes to this bug.