780446 - Infinite repeating message "Makefile is unchanged" unless clobbered (pymake build only?)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Masatoshi Kimura [:emk]]

I was not able to build even with bug 780421 and bug 780430 patch.

Comment 1

[Mike Hommey [:glandium]]

It's not infinite. It's just one for each Makefile, and is a one-time only thing. That is, after you either clobber or touch all Makefiles in the tree, it won't happen again (unless you edit a Makefile.in without modifying it, or modifying it in a way that doesn't affect its preprocessed Makefile counterpart, in which case it will only happen for that one Makefile, not all of them).

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: Touch unmodified file

to satisfy pymake...

Comment 3

[Masatoshi Kimura [:emk]]

(In reply to Mike Hommey [:glandium] from comment #1)
> It's not infinite. It's just one for each Makefile, and is a one-time only
> thing. That is, after you either clobber or touch all Makefiles in the tree,
> it won't happen again (unless you edit a Makefile.in without modifying it,
> or modifying it in a way that doesn't affect its preprocessed Makefile
> counterpart, in which case it will only happen for that one Makefile, not
> all of them).
But I observed ConfigStatus.py was called for the same one Makefile over and over.

Comment 4

[Mike Hommey [:glandium]]

Mmmm maybe pymake is not happy with the file not being modified by the rule supposedly modifying it, and it runs the rule again for other files (basically, all files depend on Makefile, so for each file it builds, it would try to rebuild Makefile).

I'd accept a patch that adds $(TOUCH) commands to the Makefile generation rules in config/rules.mk|js/src/config/rules.mk.

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: touch Makefile after invoking config.status

https://tbpl.mozilla.org/?tree=Try&rev=ba019d4354ff

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 649083 [details] [diff] [review]
touch Makefile after invoking config.status

Review of attachment 649083 [details] [diff] [review]:
-----------------------------------------------------------------

You need to do the change on the SUBMAKEFILES rule as well, and to js/src/config/rules.mk.

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 649083 [details] [diff] [review]
touch Makefile after invoking config.status

Review of attachment 649083 [details] [diff] [review]:
-----------------------------------------------------------------

You need to do the change on the SUBMAKEFILES rule as well, and to js/src/config/rules.mk.

::: config/rules.mk
@@ +1154,5 @@
>  
>  ifndef NO_MAKEFILE_RULE
>  Makefile: Makefile.in
>  	@$(PYTHON) $(DEPTH)/config.status -n --file=Makefile
> +	@$(TOUCH) Makefile

Also, just use $(TOUCH) $@

Comment 8

[Masatoshi Kimura [:emk]]

Attachment: touch Makefile after invoking config.status

(In reply to Mike Hommey [:glandium] from comment #7)
> You need to do the change on the SUBMAKEFILES rule as well, and to
> js/src/config/rules.mk.
Done.

> ::: config/rules.mk
> @@ +1154,5 @@
> >  
> >  ifndef NO_MAKEFILE_RULE
> >  Makefile: Makefile.in
> >  	@$(PYTHON) $(DEPTH)/config.status -n --file=Makefile
> > +	@$(TOUCH) Makefile
> 
> Also, just use $(TOUCH) $@
Done.

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 649089 [details] [diff] [review]
touch Makefile after invoking config.status

I'll land this shortly.

Comment 10

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24389ed3dd72

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/24389ed3dd72