780448 - rules.mk rule for python unit tests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

We have a bunch of adhoc rules here and there to run python unit tests. We should make them declarative with a variable like PY_UNIT_TESTS, that would run them during make check.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add rules for generic python unit tests

Comment 2

[Mike Hommey [:glandium]]

Attachment: Add rules for generic python unit tests

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 691315 [details] [diff] [review]
Add rules for generic python unit tests

Review of attachment 691315 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I've wanted this for a while. I take it the virtualenv changes made the pythonpath nonsense no longer necessary?

::: config/Makefile.in
@@ +65,5 @@
>  HEADERS_TARGET := export
>  INSTALL_TARGETS += HEADERS
>  
> +PYTHON_UNIT_TESTS := \
> +  $(filter-out $(srcdir)/tests/unitMozZipFile.py, \

Can we move this file out of here if it's not actually a unit test we want to run?

@@ +66,5 @@
>  INSTALL_TARGETS += HEADERS
>  
> +PYTHON_UNIT_TESTS := \
> +  $(filter-out $(srcdir)/tests/unitMozZipFile.py, \
> +    $(wildcard $(srcdir)/tests/*.py) \

Alternately you could make this unit-*.py

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/53c35671c6c2

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/53c35671c6c2