Closed Bug 780448 Opened 8 years ago Closed 7 years ago

rules.mk rule for python unit tests

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla20

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [buildfaster:?])

Attachments

(1 file, 1 obsolete file)

We have a bunch of adhoc rules here and there to run python unit tests. We should make them declarative with a variable like PY_UNIT_TESTS, that would run them during make check.
Assignee: nobody → mh+mozilla
Attachment #691310 - Attachment is obsolete: true
Attachment #691310 - Flags: review?(ted)
Comment on attachment 691315 [details] [diff] [review]
Add rules for generic python unit tests

Review of attachment 691315 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, I've wanted this for a while. I take it the virtualenv changes made the pythonpath nonsense no longer necessary?

::: config/Makefile.in
@@ +65,5 @@
>  HEADERS_TARGET := export
>  INSTALL_TARGETS += HEADERS
>  
> +PYTHON_UNIT_TESTS := \
> +  $(filter-out $(srcdir)/tests/unitMozZipFile.py, \

Can we move this file out of here if it's not actually a unit test we want to run?

@@ +66,5 @@
>  INSTALL_TARGETS += HEADERS
>  
> +PYTHON_UNIT_TESTS := \
> +  $(filter-out $(srcdir)/tests/unitMozZipFile.py, \
> +    $(wildcard $(srcdir)/tests/*.py) \

Alternately you could make this unit-*.py
Attachment #691315 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/53c35671c6c2
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Blocks: 825872
No longer blocks: 825872
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.