Port bug 780561 - Overhaul the packager - to comm-central

RESOLVED FIXED in Thunderbird 21.0

Status

MailNews Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks: 2 bugs)

Trunk
Thunderbird 21.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

+++ This bug was initially created as a clone of Bug #780561 +++

Bug 780561 is working on an overhaul of the packager, we need to have the same overhaul in comm-central to avoid bustage in comm-central.

I've tweaked the dependency list for things that I think we do need actually port, the other bugs I've removed are non-relevant things.
No longer blocks: 755724
No longer depends on: 825870, 780448, 789529
There /should/ be nothing to port from bug 780561 itself, except the flight.mk and the configure.in changes for MOZ_CHROME_FILE_FORMAT.

Comment 2

5 years ago
Created attachment 697571 [details] [diff] [review]
port everything

This are every similar things I've found between m-c and c-c. But I'm confused if every of this changes are needed, because :glandium says only the parts in flight.mk and configure.in for MOZ_CHROME_FILE_FORMAT are needed. Should I remove the other parts I've ported from the patch?
Comment on attachment 697571 [details] [diff] [review]
port everything

Actually, that looks good like that. Some of these are not strictly needed, but it's good to have them. You'll also need a few changes in other */installer directories.
Attachment #697571 - Flags: feedback+

Comment 4

5 years ago
(In reply to Mike Hommey [:glandium] from comment #3)
> You'll also need a few changes in other
> */installer directories.

Ah yes, for suite and calendar, you are right. I will do that.

Comment 5

5 years ago
Created attachment 701307 [details] [diff] [review]
port everything v2

Hm, who can I choose to review the calendar and the suite part?
Attachment #697571 - Attachment is obsolete: true
Attachment #701307 - Flags: review?(bugspam.Callek)

Comment 6

5 years ago
Comment on attachment 701307 [details] [diff] [review]
port everything v2

> Hm, who can I choose to review the calendar and the suite part?
I'd say Fallen
Attachment #701307 - Flags: review?(philipp)
(In reply to Nomis101 from comment #5)
> Created attachment 701307 [details] [diff] [review]
> port everything v2
> 
> Hm, who can I choose to review the calendar and the suite part?

Note the MOZ_CHROME_FILE_FORMAT part is missing.
Comment on attachment 701307 [details] [diff] [review]
port everything v2

I'm taking a look at this, I know Fallen is happy with me reviewing build config patches for Lightning as well.
Attachment #701307 - Flags: review?(philipp)
Attachment #701307 - Flags: review?(mbanner)
Attachment #701307 - Flags: review?(bugspam.Callek)
I haven't had time tonight, but this is my priority first thing in the morning.
Assignee: nobody → mbanner
Created attachment 705769 [details] [diff] [review]
port everything v3

This patch is pretty much the same as Nomis' patch apart from:

- Fixed bitrot in config.mk
- Ported the MOZ_CHROME_FILE_FORMAT changes in configure.in
- Ported one-line DIST_GARBAGE change in /Makefile.in from bug 785871
Attachment #701307 - Attachment is obsolete: true
Attachment #701307 - Flags: review?(mbanner)
Attachment #705769 - Flags: review+

Comment 11

5 years ago
Comment on attachment 705769 [details] [diff] [review]
port everything v3

This patch allows make package and make installer to complete successfully.
Attachment #705769 - Flags: feedback+
This landed earlier:

https://hg.mozilla.org/comm-central/rev/ead82f3bfe13

We're still waiting on other bugs to be reviewed & land before the tree will be fully green and we can reopen.
Tree is now green again.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 21.0
You need to log in before you can comment on or make changes to this bug.