780481 - Text below third-row thumbnails on about:home slightly cut off

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Peter Retzer (:pretzer)]

Attachment: Screenshot of the issue

The text below the third-row thumbnails on about:home is slightly cut off at the bottom (see screenshot).
The third row was introduced with bug 686528, I guess.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

I missed the paddingTop on the top site item RelativeLayout container.

Top site item height is the following:
RelativeLayout paddingTop:     4dp
ImageView height (id/shadow): 80dp
TextView height:              15dp
TextView marginTop:            3dp
GridView verticalSpacing:      8dp
---
Total                        110dp

Comment 2

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 649324 [details] [diff] [review]
Patch

Review of attachment 649324 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/94f020540444

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/94f020540444

Comment 5

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 649324 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 686528
User impact if declined: The text will be cut off in about:home
Testing completed (on m-c, etc.): Landed in m-c on 08/07
Risk to taking this patch (and alternatives if risky): None. Very small change
String or UUID changes made by this patch: None.

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 649324 [details] [diff] [review]
Patch

Polish, but small patch, so approving for branches.  Let's see that this gets us more ADIs :)

Comment 7

[Cristian Nicolae (:xti)]

This issue was fixed on the latest Nightly build. Leaving bug opened until the patch will land on m-a and m-b. 

--
Firefox 17.0a1 (2012-08-12)
Device: Galaxy Nexus
OS: Android 4.1.1

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Please note the patches in bug 686528 should land before this patch (the patch in bug 780367 should also land in this series).

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This didn't apply cleanly to aurora, but the unbitrotting was pretty mechanical. That said, please look it over to make sure I didn't mess anything up.

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe11110060e6

https://hg.mozilla.org/releases/mozilla-beta/rev/29e0218edeb7

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This had to be backed out due to bustage from bug 686528.

https://hg.mozilla.org/releases/mozilla-aurora/rev/1b8af79d5194
https://hg.mozilla.org/releases/mozilla-beta/rev/09e2ae313229

Comment 11

[Cristian Nicolae (:xti)]

Due to comment #10, I will close the bug as verified fixed.

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Reopening due to comment 10, this isn't landed.

Comment 13

[Peter Retzer (:pretzer)]

This was backed out only on Aurora and Beta. It's still fixed on m-c, afaics.

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

thanks - updating status flags, as I should have done instead of reopening :)

Comment 15

[Sriram Ramasubramanian [:sriram]]

Pushed to beta: https://hg.mozilla.org/releases/mozilla-beta/rev/123f0b08a7ac

Comment 16

[Sriram Ramasubramanian [:sriram]]

And to aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/ecff9596cfba