780486 - 'Top sites' heading background overlaps Firefox icon on about:home

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Peter Retzer (:pretzer)]

Attachment: Screenshots of the change

The background for the 'Top sites' heading on about:home now overlaps the Firefox icon since bug 686528 landed.
The highlight had a nice fade-out effect before which can also be seen on Ian's mockup here:
http://www.flickr.com/photos/61892693@N03/7638102288/in/set-72157630730911182
See the screenshot to see how it changed.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This was an intentional change in bug 686528 to simplify the layout code... But I probably should have asked UX if it was okay first.

Ian, do you want this fixed?

Additionally, with bug 766389, I was going to play around with placing a "My Apps" button above the "Top Sites" title bar (which means displacing the logo) in addition to changing the sync box (as suggested by Wesj), to make web apps more discoverable. I don't have a mockup for my idea yet but I can make one if you want me to. Doing this would make fixing this bug unnecessary... so how does that sound? (I also think the logo can be a bit silly since it's repeated in the about:home favicon.)

Comment 2

[Ian Barlow (:ibarlow)]

Yes, please fix this, the bar should never sit on top of the logo.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: 01: Draw order on phones

Fixing this on the xlarge-land config is gross... but here is the fix for all other configs.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 652124 [details] [diff] [review]
01: Draw order on phones

Review of attachment 652124 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e86c64641778

Comment 6

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 652124 [details] [diff] [review]
01: Draw order on phones

[Approval Request Comment]
Bug caused by (feature/regressing bug #): about:home for tablets
User impact if declined: Logo will have a white band on top.
Testing completed (on m-c, etc.): Landed on m-i just now ( ;) )
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: None.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 652124 [details] [diff] [review]
01: Draw order on phones

mobile-only and minor

Comment 8

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/6fcd56ab70f0

And to beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/31aacbde98ad

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e86c64641778