The default bug view has changed. See this FAQ.

Webapp uninstallation on Linux through desktop action

RESOLVED FIXED in Firefox 17

Status

Firefox Graveyard
Webapp Runtime
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: marco, Assigned: marco)

Tracking

Trunk
Firefox 17
All
Linux
Bug Flags:
in-testsuite -

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Depends on: 761806
Created attachment 649157 [details] [diff] [review]
Patch
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #649157 - Flags: review?(chrisccoulson)
Created attachment 652637 [details] [diff] [review]
Patch

Applies on top of the patch in bug 780530 (that adds the browserBundle variable).
The patch is really simple, here's the freedesktop.org specification about additional app actions: http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#extra-actions
Attachment #649157 - Attachment is obsolete: true
Attachment #649157 - Flags: review?(chrisccoulson)
Attachment #652637 - Flags: review?(karlt)
Attachment #652637 - Flags: review?(chrisccoulson)
Comment on attachment 652637 [details] [diff] [review]
Patch

Do any other apps have Remove actions?
What do they use for "Name"?
I wonder whether "Uninstall" might be better than "Remove", if "Remove" could be interpreted as just removing the app from a menu?

The Exec string above peudoquotes the path.
This Exec string should at least be consistent in the quoting it uses.
(In reply to Karl Tomlinson (:karlt) from comment #3)
> Comment on attachment 652637 [details] [diff] [review]
> Patch
> 
> Do any other apps have Remove actions?
> What do they use for "Name"?

No other app has such an action (as normally they are removed manually or through a package manager).

> I wonder whether "Uninstall" might be better than "Remove", if "Remove"
> could be interpreted as just removing the app from a menu?

Yes, "Uninstall" is probably better. I'll use it.

> The Exec string above peudoquotes the path.
> This Exec string should at least be consistent in the quoting it uses.

The quotes aren't needed, I'm removing them in another patch in another bug.
Attachment #652637 - Flags: review?(karlt)
Attachment #652637 - Flags: review?(chrisccoulson)
Attachment #652637 - Flags: review+
Created attachment 652809 [details] [diff] [review]
Patch

Carrying forward r+.
Before landing this, the patch in bug 780530 should land.
Attachment #652637 - Attachment is obsolete: true
Keywords: checkin-needed
Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=e01235322203

https://hg.mozilla.org/integration/mozilla-inbound/rev/007530514a39
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/007530514a39
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.