780528 - Webapp uninstallation on Linux through desktop action

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Marco Castelluccio [:marco]]

Attachment: Patch

Applies on top of the patch in bug 780530 (that adds the browserBundle variable).
The patch is really simple, here's the freedesktop.org specification about additional app actions: http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#extra-actions

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 652637 [details] [diff] [review]
Patch

Do any other apps have Remove actions?
What do they use for "Name"?
I wonder whether "Uninstall" might be better than "Remove", if "Remove" could be interpreted as just removing the app from a menu?

The Exec string above peudoquotes the path.
This Exec string should at least be consistent in the quoting it uses.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Karl Tomlinson (:karlt) from comment #3)
> Comment on attachment 652637 [details] [diff] [review]
> Patch
> 
> Do any other apps have Remove actions?
> What do they use for "Name"?

No other app has such an action (as normally they are removed manually or through a package manager).

> I wonder whether "Uninstall" might be better than "Remove", if "Remove"
> could be interpreted as just removing the app from a menu?

Yes, "Uninstall" is probably better. I'll use it.

> The Exec string above peudoquotes the path.
> This Exec string should at least be consistent in the quoting it uses.

The quotes aren't needed, I'm removing them in another patch in another bug.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: Patch

Carrying forward r+.
Before landing this, the patch in bug 780530 should land.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Green on Try.
https://tbpl.mozilla.org/?tree=Try&rev=e01235322203

https://hg.mozilla.org/integration/mozilla-inbound/rev/007530514a39

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/007530514a39