Last Comment Bug 780528 - Webapp uninstallation on Linux through desktop action
: Webapp uninstallation on Linux through desktop action
Status: RESOLVED FIXED
:
Product: Firefox Graveyard
Classification: Graveyard
Component: Webapp Runtime (show other bugs)
: Trunk
: All Linux
: -- normal
: Firefox 17
Assigned To: Marco Castelluccio [:marco]
: Jason Smith [:jsmith]
:
Mentors:
Depends on: 761806
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-05 17:32 PDT by Marco Castelluccio [:marco]
Modified: 2016-03-21 12:39 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (3.49 KB, patch)
2012-08-05 17:39 PDT, Marco Castelluccio [:marco]
no flags Details | Diff | Splinter Review
Patch (2.68 KB, patch)
2012-08-16 17:52 PDT, Marco Castelluccio [:marco]
karlt: review+
Details | Diff | Splinter Review
Patch (2.69 KB, patch)
2012-08-17 10:10 PDT, Marco Castelluccio [:marco]
no flags Details | Diff | Splinter Review

Description Marco Castelluccio [:marco] 2012-08-05 17:32:26 PDT

    
Comment 1 Marco Castelluccio [:marco] 2012-08-05 17:39:39 PDT
Created attachment 649157 [details] [diff] [review]
Patch
Comment 2 Marco Castelluccio [:marco] 2012-08-16 17:52:21 PDT
Created attachment 652637 [details] [diff] [review]
Patch

Applies on top of the patch in bug 780530 (that adds the browserBundle variable).
The patch is really simple, here's the freedesktop.org specification about additional app actions: http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#extra-actions
Comment 3 Karl Tomlinson (:karlt) 2012-08-16 19:42:43 PDT
Comment on attachment 652637 [details] [diff] [review]
Patch

Do any other apps have Remove actions?
What do they use for "Name"?
I wonder whether "Uninstall" might be better than "Remove", if "Remove" could be interpreted as just removing the app from a menu?

The Exec string above peudoquotes the path.
This Exec string should at least be consistent in the quoting it uses.
Comment 4 Marco Castelluccio [:marco] 2012-08-16 19:49:34 PDT
(In reply to Karl Tomlinson (:karlt) from comment #3)
> Comment on attachment 652637 [details] [diff] [review]
> Patch
> 
> Do any other apps have Remove actions?
> What do they use for "Name"?

No other app has such an action (as normally they are removed manually or through a package manager).

> I wonder whether "Uninstall" might be better than "Remove", if "Remove"
> could be interpreted as just removing the app from a menu?

Yes, "Uninstall" is probably better. I'll use it.

> The Exec string above peudoquotes the path.
> This Exec string should at least be consistent in the quoting it uses.

The quotes aren't needed, I'm removing them in another patch in another bug.
Comment 5 Marco Castelluccio [:marco] 2012-08-17 10:10:15 PDT
Created attachment 652809 [details] [diff] [review]
Patch

Carrying forward r+.
Before landing this, the patch in bug 780530 should land.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-08-18 16:19:35 PDT
https://hg.mozilla.org/mozilla-central/rev/007530514a39

Note You need to log in before you can comment on or make changes to this bug.