780691 - DeviceStorage - Add onchange notifications for volume state changes

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

Attachment: -w patch - same as v.1

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 649365 [details] [diff] [review]
patch v.1

Review of attachment 649365 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/devicestorage/nsDeviceStorage.cpp
@@ +1563,5 @@
> +  nsCOMPtr<nsIDOMEvent> event;
> +  NS_NewDOMDeviceStorageChangeEvent(getter_AddRefs(event), nullptr, nullptr);
> +
> +  nsCOMPtr<nsIDOMDeviceStorageChangeEvent> ce = do_QueryInterface(event);
> +  nsresult rv = ce->InitDeviceStorageChangeEvent(NS_LITERAL_STRING("change"),

I actually tend to prefer to fire different events for enabled/disabled-like things, so here separate events for "mounted" and "unmounted". But I think this is fine for now.

@@ +1608,5 @@
> +    NS_NewLocalFile(filepath, false, getter_AddRefs(f));
> + 
> +    nsCString creason;
> +    creason.AssignWithConversion(reason);
> +    CopyUTF16toUTF8(reason, creason);

You're assigning twice. Remove the .AssignWithConversion line.

Comment 4

[Doug Turner (:dougt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc583bf8519c

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc583bf8519c