Closed Bug 780693 Opened 9 years ago Closed 9 years ago

IPC VolumeManager on Gonk

Categories

(Core Graveyard :: Widget: Gonk, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-basecamp:+)

RESOLVED FIXED
mozilla17
blocking-basecamp +

People

(Reporter: dougt, Assigned: dougt)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch v.1 (obsolete) — Splinter Review
This patch forwards notifications from the volume manager to the child process.
It also allow you to synchronously learn about the status of a give named volume.

David and I both touched this patch.  Kyle, can you look at this?
Attachment #649370 - Flags: review?(kyle)
Blocks: 780691
Comment on attachment 649370 [details] [diff] [review]
patch v.1

not the right patch.
Attachment #649370 - Flags: review?(kyle) → review-
Attached patch patch v.1 (obsolete) — Splinter Review
Attachment #649370 - Attachment is obsolete: true
Attachment #649409 - Flags: review?(bent.mozilla)
blocking-basecamp: --- → +
Attached patch patch v.2Splinter Review
without that sync method
Attachment #649409 - Attachment is obsolete: true
Attachment #649409 - Flags: review?(bent.mozilla)
Attachment #650678 - Flags: review?(bent.mozilla)
Comment on attachment 650678 [details] [diff] [review]
patch v.2

Review of attachment 650678 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/Makefile.in
@@ +69,5 @@
>    $(NULL)
>  # for our local copy of AudioSystem.h
>  LOCAL_INCLUDES += -I$(topsrcdir)/media/libsydneyaudio/src
> +
> +EXPORTS     = \

Nit: too much whitespace there.
Attachment #650678 - Flags: review?(bent.mozilla) → review+
I rearranged the ContentChild constructor to fix warnings-as-errors:

https://hg.mozilla.org/integration/mozilla-inbound/rev/14c4b37f9a0e
https://hg.mozilla.org/mozilla-central/rev/5334f92a9f34
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.