Last Comment Bug 780693 - IPC VolumeManager on Gonk
: IPC VolumeManager on Gonk
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Gonk (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Doug Turner (:dougt)
:
:
Mentors:
Depends on:
Blocks: 780691
  Show dependency treegraph
 
Reported: 2012-08-06 13:05 PDT by Doug Turner (:dougt)
Modified: 2012-08-10 05:46 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
+


Attachments
patch v.1 (7.53 KB, patch)
2012-08-06 13:05 PDT, Doug Turner (:dougt)
doug.turner: review-
Details | Diff | Splinter Review
patch v.1 (13.71 KB, patch)
2012-08-06 14:04 PDT, Doug Turner (:dougt)
no flags Details | Diff | Splinter Review
patch v.2 (11.28 KB, patch)
2012-08-09 14:23 PDT, Doug Turner (:dougt)
bent.mozilla: review+
Details | Diff | Splinter Review

Description Doug Turner (:dougt) 2012-08-06 13:05:03 PDT
Created attachment 649370 [details] [diff] [review]
patch v.1

This patch forwards notifications from the volume manager to the child process.
It also allow you to synchronously learn about the status of a give named volume.

David and I both touched this patch.  Kyle, can you look at this?
Comment 1 Doug Turner (:dougt) 2012-08-06 13:52:52 PDT
Comment on attachment 649370 [details] [diff] [review]
patch v.1

not the right patch.
Comment 2 Doug Turner (:dougt) 2012-08-06 14:04:52 PDT
Created attachment 649409 [details] [diff] [review]
patch v.1
Comment 3 Doug Turner (:dougt) 2012-08-09 14:23:25 PDT
Created attachment 650678 [details] [diff] [review]
patch v.2

without that sync method
Comment 4 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-08-09 15:27:33 PDT
Comment on attachment 650678 [details] [diff] [review]
patch v.2

Review of attachment 650678 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/Makefile.in
@@ +69,5 @@
>    $(NULL)
>  # for our local copy of AudioSystem.h
>  LOCAL_INCLUDES += -I$(topsrcdir)/media/libsydneyaudio/src
> +
> +EXPORTS     = \

Nit: too much whitespace there.
Comment 6 :Benjamin Peterson 2012-08-09 16:38:01 PDT
I rearranged the ContentChild constructor to fix warnings-as-errors:

https://hg.mozilla.org/integration/mozilla-inbound/rev/14c4b37f9a0e
Comment 7 Ed Morley [:emorley] 2012-08-10 01:58:36 PDT
https://hg.mozilla.org/mozilla-central/rev/5334f92a9f34
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-08-10 05:46:23 PDT
And the follow-up:
https://hg.mozilla.org/mozilla-central/rev/14c4b37f9a0e

Note You need to log in before you can comment on or make changes to this bug.