Last Comment Bug 780739 - B2G: Suppress gcc warnings about va_list mangling
: B2G: Suppress gcc warnings about va_list mangling
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla17
Assigned To: Marshall Culpepper [:marshall_law]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-06 15:04 PDT by Marshall Culpepper [:marshall_law]
Modified: 2012-08-08 09:35 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (3.00 KB, patch)
2012-08-06 15:49 PDT, Marshall Culpepper [:marshall_law]
ted: review+
Details | Diff | Splinter Review

Description Marshall Culpepper [:marshall_law] 2012-08-06 15:04:21 PDT
When building gecko from B2G, that contain this message about va_list:

> note: the mangling of 'va_list' has changed in GCC 4.4

These warnings have already been suppressed for Fennec (see Bug 760335), we just need to add -Wno-psabi to the right places to make the B2G build configuration happy
Comment 1 Marshall Culpepper [:marshall_law] 2012-08-06 15:08:04 PDT
* When building gecko from B2G, there are a sea of warnings that contain this message about va_list
Comment 2 Marshall Culpepper [:marshall_law] 2012-08-06 15:49:38 PDT
Created attachment 649441 [details] [diff] [review]
v1
Comment 3 Ted Mielczarek [:ted.mielczarek] 2012-08-07 05:16:54 PDT
Comment on attachment 649441 [details] [diff] [review]
v1

Yes, please!

(FYI, you'll usually get better results by setting review?someone than just setting review?.)
Comment 4 Marshall Culpepper [:marshall_law] 2012-08-07 08:03:59 PDT
(In reply to Ted Mielczarek [:ted] from comment #3)

> (FYI, you'll usually get better results by setting review?someone than just
> setting review?.)

I used git-bz-moz to attach the patch and I guess my r=vlad flag didn't get set correctly, my bad :) Thanks for taking up the review!
Comment 5 Marshall Culpepper [:marshall_law] 2012-08-07 10:46:59 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/13e6a06bc805
Comment 6 Ed Morley [:emorley] 2012-08-08 09:35:11 PDT
https://hg.mozilla.org/mozilla-central/rev/13e6a06bc805

Note You need to log in before you can comment on or make changes to this bug.