Closed Bug 780739 Opened 7 years ago Closed 7 years ago

B2G: Suppress gcc warnings about va_list mangling

Categories

(Firefox Build System :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla17

People

(Reporter: marshall, Assigned: marshall)

Details

Attachments

(1 file)

When building gecko from B2G, that contain this message about va_list:

> note: the mangling of 'va_list' has changed in GCC 4.4

These warnings have already been suppressed for Fennec (see Bug 760335), we just need to add -Wno-psabi to the right places to make the B2G build configuration happy
* When building gecko from B2G, there are a sea of warnings that contain this message about va_list
Attached patch v1Splinter Review
Attachment #649441 - Flags: review?
Assignee: nobody → marshall
Comment on attachment 649441 [details] [diff] [review]
v1

Yes, please!

(FYI, you'll usually get better results by setting review?someone than just setting review?.)
Attachment #649441 - Flags: review? → review+
(In reply to Ted Mielczarek [:ted] from comment #3)

> (FYI, you'll usually get better results by setting review?someone than just
> setting review?.)

I used git-bz-moz to attach the patch and I guess my r=vlad flag didn't get set correctly, my bad :) Thanks for taking up the review!
https://hg.mozilla.org/mozilla-central/rev/13e6a06bc805
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.