781020 - SwiftKey backspace can't delete some characters

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect, P2)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Load https://support.mozilla.org/en-US/mobile
2. Using SwiftKey IME, type "q" then press BACKSPACE key
3. The "q" string will be deleted, as expected.
4. Now type "q " (with a space)
5. Try to delete "q " with BACKSPACE key.

ER:
The string is deleted.

AR:
You can delete the " " space, but not the "q".

Comment 1

[Chris Peterson [:cpeterson]]

This bug is a regression from TouchPal bug 768106.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: remove-composing-spans.patch

Remove IME's composing spans when Gecko resets the composition state.

This patch alerts the IME to stop composing when form autocomplete inserts new text. I can remove the broken workaround for TouchPal bug 768106 because the IME knows the correct composing state and knows not to delete the autocompleted text.

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1967d96747a8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1967d96747a8

Comment 5

[Chris Peterson [:cpeterson]]

Comment on attachment 650691 [details] [diff] [review]
remove-composing-spans.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug  	768106
User impact if declined: SwiftKey backspace key will not delete some characters. This is very bad user experience.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): This patch removes a workaround for a TouchPal IME bug. This patch will fix both bugs. Beta 15 is unaffected because this regression was caused when we re-enabled form autocomplete popup.
String or UUID changes made by this patch: N/A

Comment 6

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b9245270095d

Comment 7

[Adrian Tamas (:AdrianT)]

Verified fix on: Firefox Mobile 16 beta 2, Nightly 18.0a1 2012-09-04 and Aurora 17.0a2 2012-09-05 on Samsung Galaxy Tab 2 7.0 (Android 4.0.4) - Swiftkey 3 Tablet and Samsung Galaxy R (Android 2.3.4) - Swiftkey 3