Closed
Bug 781240
Opened 12 years ago
Closed 10 years ago
change default wallpaper on 10.8 talos slaves to a solid colour
Categories
(Infrastructure & Operations Graveyard :: CIDuty, task)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: kmoir, Assigned: kmoir)
References
Details
Attachments
(1 file, 1 obsolete file)
1.77 KB,
patch
|
dustin
:
review+
kmoir
:
checked-in+
|
Details | Diff | Splinter Review |
As requested by philor
philor kmoir: does Mountain Lion have a lovely and gradient-filled default wallpaper like previous versions do, and is it too late to switch the ref image to use a solid color instead?
philor a data: URI of a screenshot of the lovely nebula and stars from a shutdown timeout is brutally bigger than it ought to be
kmoir philor: yes, gradient filled wallpaper. I can open a bug to change it to a solid colour
kmoir and take a look at that
philor yay!
catlee-buildduty should be unicorns instead
philor did Escher do interlocking unicorns? that'd give two solid colors, still cheap
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → kmoir
Comment 1•12 years ago
|
||
Release Engineers connected to the US via a soggy string are also in favour of this scheme!
Assignee | ||
Comment 2•12 years ago
|
||
This patch sets the default background to blue and restarts the Dock. I was unable to use the osxutils::defaults module to implement this because the value set by the command line via write is different from the one you read. I tried to refactor the defaults module to accommodate this but it was very ugly. Also, I had to copy and call a shell script to run the defaults command to change the background because puppet doesn't escape the characters properly when running the exec command. The same command I could run from the command line didn't work when escaped and run through exec. I've did some reading about this on the puppet forums and many people have run into the same problem.
Attachment #651390 -
Flags: review?(dustin)
Comment 3•12 years ago
|
||
Comment on attachment 651390 [details] [diff] [review]
patch
This should probably *not* be in the talos class, since it's not talos-specific (we'll probably want any host that's running VNC to do this). Maybe putting it in a new class in the vnc module, and including that from the vnc class, makes sense?
Also, your notifies aren't quite right here - the notify for the dock comes from the file resource, rather than the *execution* of that script.
Finally, you're running the script as root, so it should probably be installed as root, rather than the builder user, on general principles.
Attachment #651390 -
Flags: review?(dustin) → review-
Assignee | ||
Comment 4•12 years ago
|
||
Attachment #651390 -
Attachment is obsolete: true
Attachment #651506 -
Flags: review?(dustin)
Updated•12 years ago
|
Attachment #651506 -
Flags: review?(dustin) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #651506 -
Flags: checked-in+
Comment 5•12 years ago
|
||
The VNC module wants some docs, too:
https://wiki.mozilla.org/index.php?title=ReleaseEngineering/PuppetAgain/Modules/vnc&action=edit&redlink=1
Assignee | ||
Comment 6•12 years ago
|
||
Docs have been updated.
Assignee | ||
Comment 7•12 years ago
|
||
It seems this change doesn't work on all attached monitors, including screenshare. I thought it worked before because I was testing it running puppet from the vnc screen. However, if you run it while logged into ssh on the client, the default galaxy image still appears when you connect via vnc. Investigating a better fix.
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
Assignee | ||
Comment 8•10 years ago
|
||
I couldn't get this to work and we are close to deprecating 10.8 so I'm going to close this bug.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Updated•6 years ago
|
Component: Platform Support → Buildduty
Product: Release Engineering → Infrastructure & Operations
Updated•5 years ago
|
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•