The default bug view has changed. See this FAQ.

Do not add stack to result if assertion passes

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

unspecified

Firefox Tracking Flags

(firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox17 fixed, firefox-esr10 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
See bug 781376 for the fix in Mozmill 2.0 base. We need the same for our Mozmill tests which we run for 1.5. So this bug will cover the fix in the mozmill-tests repository.

With this patch our reports will become way smaller and take lesser space in the db.
(Assignee)

Comment 1

5 years ago
Created attachment 650473 [details] [diff] [review]
Patch v1

Simply and easy to understand fix. Vlad, can you please review given that Dave is not available atm? Thanks
Attachment #650473 - Flags: review?(vlad.mozbugs)
Comment on attachment 650473 [details] [diff] [review]
Patch v1

Fairly an r+
Attachment #650473 - Flags: review?(vlad.mozbugs) → review+
(Assignee)

Comment 3

5 years ago
Just for comparison, the numbers speak themselves:

-rw-r--r--@  1 henrik  staff  264310 Aug  9 11:26 new.txt
-rw-r--r--@  1 henrik  staff  728381 Aug  9 11:27 old.txt

It's a reduction of 64% in size of a report.
(Assignee)

Comment 4

5 years ago
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/797913f70234

Lets wait for todays testrun on 17.0 and then we should backport.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox-esr10: --- → affected
status-firefox14: --- → affected
status-firefox15: --- → affected
status-firefox16: --- → affected
status-firefox17: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 5

5 years ago
Landed on older branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/ce8dcb9914f0 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/76fab8b7da75 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/d6b404df056f (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/69dc19050dfb (esr10)
status-firefox-esr10: affected → fixed
status-firefox14: affected → fixed
status-firefox15: affected → fixed
status-firefox16: affected → fixed
You need to log in before you can comment on or make changes to this bug.