Last Comment Bug 781464 - Do not add stack to result if assertion passes
: Do not add stack to result if assertion passes
Product: Mozilla QA
Classification: Other
Component: Mozmill Tests (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: Henrik Skupin (:whimboo)
Depends on:
  Show dependency treegraph
Reported: 2012-08-09 02:17 PDT by Henrik Skupin (:whimboo)
Modified: 2012-08-09 05:33 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---

Patch v1 (1.04 KB, patch)
2012-08-09 02:19 PDT, Henrik Skupin (:whimboo)
vlad.mozbugs: review+
Details | Diff | Splinter Review

Description User image Henrik Skupin (:whimboo) 2012-08-09 02:17:03 PDT
See bug 781376 for the fix in Mozmill 2.0 base. We need the same for our Mozmill tests which we run for 1.5. So this bug will cover the fix in the mozmill-tests repository.

With this patch our reports will become way smaller and take lesser space in the db.
Comment 1 User image Henrik Skupin (:whimboo) 2012-08-09 02:19:00 PDT
Created attachment 650473 [details] [diff] [review]
Patch v1

Simply and easy to understand fix. Vlad, can you please review given that Dave is not available atm? Thanks
Comment 2 User image Maniac Vlad Florin (:vladmaniac) 2012-08-09 02:28:48 PDT
Comment on attachment 650473 [details] [diff] [review]
Patch v1

Fairly an r+
Comment 3 User image Henrik Skupin (:whimboo) 2012-08-09 02:29:35 PDT
Just for comparison, the numbers speak themselves:

-rw-r--r--@  1 henrik  staff  264310 Aug  9 11:26 new.txt
-rw-r--r--@  1 henrik  staff  728381 Aug  9 11:27 old.txt

It's a reduction of 64% in size of a report.
Comment 4 User image Henrik Skupin (:whimboo) 2012-08-09 02:32:15 PDT
Landed on default:

Lets wait for todays testrun on 17.0 and then we should backport.

Note You need to log in before you can comment on or make changes to this bug.