Closed Bug 781494 Opened 7 years ago Closed 7 years ago

Code cleanup in nsMathMLChar

Categories

(Core :: MathML, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: fredw, Assigned: fredw)

References

Details

Attachments

(4 files)

No description provided.
Attached patch Patch - part 1Splinter Review
Assignee: nobody → fred.wang
Status: NEW → ASSIGNED
Attachment #650515 - Flags: review?(karlt)
Attached patch Patch - part 2Splinter Review
Attachment #650516 - Flags: review?(karlt)
Should we remove the "#if 0", too?
Attachment #650515 - Flags: review?(karlt) → review+
(In reply to Frédéric Wang (:fredw) from comment #3)
> Should we remove the "#if 0", too?

Yes, I think that can go.
Comment on attachment 650516 [details] [diff] [review]
Patch - part 2

I'm a bit hesitant about the effect of reformatting on history, but, if it improves readability, then there is value in it.
Attachment #650516 - Flags: review?(karlt) → review+
Attached patch Patch - part 3Splinter Review
Attachment #650829 - Flags: review?(karlt)
Attachment #650829 - Flags: review?(karlt) → review+
Keywords: checkin-needed
Finally, I think I'll remove the composite char support in this bug too, so please leave it open.
No longer blocks: 732832
Whiteboard: [leave open for remaining patches]
Comment on attachment 651122 [details] [diff] [review]
Patch - part 4

The tinderbox results look good.
Attachment #651122 - Flags: review?(karlt)
Attachment #651122 - Flags: review?(karlt) → review+
Keywords: checkin-needed
Attachment #650515 - Flags: checkin+
Attachment #650516 - Flags: checkin+
Attachment #650829 - Flags: checkin+
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/f9094ef74bf3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.