The default bug view has changed. See this FAQ.

Code cleanup in nsMathMLChar

RESOLVED FIXED in mozilla17

Status

()

Core
MathML
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: fredw, Assigned: fredw)

Tracking

Trunk
mozilla17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 650515 [details] [diff] [review]
Patch - part 1
Assignee: nobody → fred.wang
Status: NEW → ASSIGNED
Attachment #650515 - Flags: review?(karlt)
(Assignee)

Comment 2

5 years ago
Created attachment 650516 [details] [diff] [review]
Patch - part 2
Attachment #650516 - Flags: review?(karlt)
(Assignee)

Comment 3

5 years ago
Should we remove the "#if 0", too?
Attachment #650515 - Flags: review?(karlt) → review+
(In reply to Frédéric Wang (:fredw) from comment #3)
> Should we remove the "#if 0", too?

Yes, I think that can go.
Comment on attachment 650516 [details] [diff] [review]
Patch - part 2

I'm a bit hesitant about the effect of reformatting on history, but, if it improves readability, then there is value in it.
Attachment #650516 - Flags: review?(karlt) → review+
(Assignee)

Comment 6

5 years ago
Created attachment 650829 [details] [diff] [review]
Patch - part 3
Attachment #650829 - Flags: review?(karlt)
Attachment #650829 - Flags: review?(karlt) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Green on Try:
https://tbpl.mozilla.org/?tree=Try&rev=1d57b70df30c

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a43488f1543
https://hg.mozilla.org/integration/mozilla-inbound/rev/54568120778a
https://hg.mozilla.org/integration/mozilla-inbound/rev/343e745e4016
Flags: in-testsuite-
Keywords: checkin-needed
(Assignee)

Comment 8

5 years ago
Finally, I think I'll remove the composite char support in this bug too, so please leave it open.
No longer blocks: 732832
Whiteboard: [leave open for remaining patches]
(Assignee)

Comment 9

5 years ago
Created attachment 651122 [details] [diff] [review]
Patch - part 4

https://tbpl.mozilla.org/?tree=Try&rev=168bab0e434a
(Assignee)

Comment 10

5 years ago
Comment on attachment 651122 [details] [diff] [review]
Patch - part 4

The tinderbox results look good.
Attachment #651122 - Flags: review?(karlt)
https://hg.mozilla.org/mozilla-central/rev/8a43488f1543
https://hg.mozilla.org/mozilla-central/rev/54568120778a
https://hg.mozilla.org/mozilla-central/rev/343e745e4016
Whiteboard: [leave open for remaining patches] → [leave open]
Attachment #651122 - Flags: review?(karlt) → review+
(Assignee)

Comment 12

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=8284443124e8
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Attachment #650515 - Flags: checkin+
Attachment #650516 - Flags: checkin+
Attachment #650829 - Flags: checkin+
Comment on attachment 651122 [details] [diff] [review]
Patch - part 4

(In reply to Frédéric Wang (:fredw) from comment #12)
> https://tbpl.mozilla.org/?tree=Try&rev=8284443124e8

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9094ef74bf3
Attachment #651122 - Flags: checkin+
Keywords: checkin-needed
(Assignee)

Updated

5 years ago
Whiteboard: [leave open]
https://hg.mozilla.org/mozilla-central/rev/f9094ef74bf3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.