Closed
Bug 781494
Opened 14 years ago
Closed 14 years ago
Code cleanup in nsMathMLChar
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: fwang, Assigned: fwang)
References
Details
Attachments
(4 files)
|
7.04 KB,
patch
|
karlt
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
|
36.51 KB,
patch
|
karlt
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
|
1.75 KB,
patch
|
karlt
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
|
31.61 KB,
patch
|
karlt
:
review+
RyanVM
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•14 years ago
|
||
|
|
Assignee | |
Comment 2•14 years ago
|
||
Attachment #650516 -
Flags: review?(karlt)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Should we remove the "#if 0", too?
|
||
Updated•14 years ago
|
Attachment #650515 -
Flags: review?(karlt) → review+
|
|
||
Comment 4•14 years ago
|
||
(In reply to Frédéric Wang (:fredw) from comment #3)
> Should we remove the "#if 0", too?
Yes, I think that can go.
|
|
||
Comment 5•14 years ago
|
||
Comment on attachment 650516 [details] [diff] [review]
Patch - part 2
I'm a bit hesitant about the effect of reformatting on history, but, if it improves readability, then there is value in it.
Attachment #650516 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #650829 -
Flags: review?(karlt)
|
|
||
Updated•14 years ago
|
Attachment #650829 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 7•14 years ago
|
||
Green on Try:
https://tbpl.mozilla.org/?tree=Try&rev=1d57b70df30c
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a43488f1543
https://hg.mozilla.org/integration/mozilla-inbound/rev/54568120778a
https://hg.mozilla.org/integration/mozilla-inbound/rev/343e745e4016
Flags: in-testsuite-
Keywords: checkin-needed
|
|
Assignee | |
Comment 8•14 years ago
|
||
Finally, I think I'll remove the composite char support in this bug too, so please leave it open.
No longer blocks: 732832
Whiteboard: [leave open for remaining patches]
|
|
Assignee | |
Comment 9•14 years ago
|
||
|
|
Assignee | |
Comment 10•14 years ago
|
||
Comment on attachment 651122 [details] [diff] [review]
Patch - part 4
The tinderbox results look good.
Attachment #651122 -
Flags: review?(karlt)
|
|
||
Comment 11•14 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a43488f1543
https://hg.mozilla.org/mozilla-central/rev/54568120778a
https://hg.mozilla.org/mozilla-central/rev/343e745e4016
Whiteboard: [leave open for remaining patches] → [leave open]
|
|
||
Updated•14 years ago
|
Attachment #651122 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 12•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Updated•14 years ago
|
Attachment #650515 -
Flags: checkin+
|
|
||
Updated•14 years ago
|
Attachment #650516 -
Flags: checkin+
|
|
||
Updated•14 years ago
|
Attachment #650829 -
Flags: checkin+
|
|
||
Comment 13•14 years ago
|
||
Comment on attachment 651122 [details] [diff] [review]
Patch - part 4
(In reply to Frédéric Wang (:fredw) from comment #12)
> https://tbpl.mozilla.org/?tree=Try&rev=8284443124e8
Green on Try.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9094ef74bf3
Attachment #651122 -
Flags: checkin+
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [leave open]
|
||
Comment 14•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•