Last Comment Bug 781494 - Code cleanup in nsMathMLChar
: Code cleanup in nsMathMLChar
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MathML (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla17
Assigned To: Frédéric Wang (:fredw)
:
Mentors:
Depends on:
Blocks: 663740
  Show dependency treegraph
 
Reported: 2012-08-09 05:43 PDT by Frédéric Wang (:fredw)
Modified: 2012-08-21 06:29 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch - part 1 (7.04 KB, patch)
2012-08-09 05:44 PDT, Frédéric Wang (:fredw)
karlt: review+
ryanvm: checkin+
Details | Diff | Splinter Review
Patch - part 2 (36.51 KB, patch)
2012-08-09 05:44 PDT, Frédéric Wang (:fredw)
karlt: review+
ryanvm: checkin+
Details | Diff | Splinter Review
Patch - part 3 (1.75 KB, patch)
2012-08-10 01:49 PDT, Frédéric Wang (:fredw)
karlt: review+
ryanvm: checkin+
Details | Diff | Splinter Review
Patch - part 4 (31.61 KB, patch)
2012-08-11 09:01 PDT, Frédéric Wang (:fredw)
karlt: review+
ryanvm: checkin+
Details | Diff | Splinter Review

Description Frédéric Wang (:fredw) 2012-08-09 05:43:11 PDT

    
Comment 1 Frédéric Wang (:fredw) 2012-08-09 05:44:11 PDT
Created attachment 650515 [details] [diff] [review]
Patch - part 1
Comment 2 Frédéric Wang (:fredw) 2012-08-09 05:44:36 PDT
Created attachment 650516 [details] [diff] [review]
Patch - part 2
Comment 3 Frédéric Wang (:fredw) 2012-08-09 14:17:01 PDT
Should we remove the "#if 0", too?
Comment 4 Karl Tomlinson (:karlt) 2012-08-09 20:03:26 PDT
(In reply to Frédéric Wang (:fredw) from comment #3)
> Should we remove the "#if 0", too?

Yes, I think that can go.
Comment 5 Karl Tomlinson (:karlt) 2012-08-09 20:05:36 PDT
Comment on attachment 650516 [details] [diff] [review]
Patch - part 2

I'm a bit hesitant about the effect of reformatting on history, but, if it improves readability, then there is value in it.
Comment 6 Frédéric Wang (:fredw) 2012-08-10 01:49:27 PDT
Created attachment 650829 [details] [diff] [review]
Patch - part 3
Comment 8 Frédéric Wang (:fredw) 2012-08-11 05:48:01 PDT
Finally, I think I'll remove the composite char support in this bug too, so please leave it open.
Comment 9 Frédéric Wang (:fredw) 2012-08-11 09:01:47 PDT
Created attachment 651122 [details] [diff] [review]
Patch - part 4

https://tbpl.mozilla.org/?tree=Try&rev=168bab0e434a
Comment 10 Frédéric Wang (:fredw) 2012-08-11 12:40:12 PDT
Comment on attachment 651122 [details] [diff] [review]
Patch - part 4

The tinderbox results look good.
Comment 12 Frédéric Wang (:fredw) 2012-08-20 00:54:31 PDT
https://tbpl.mozilla.org/?tree=Try&rev=8284443124e8
Comment 13 Ryan VanderMeulen [:RyanVM] 2012-08-20 17:23:22 PDT
Comment on attachment 651122 [details] [diff] [review]
Patch - part 4

(In reply to Frédéric Wang (:fredw) from comment #12)
> https://tbpl.mozilla.org/?tree=Try&rev=8284443124e8

Green on Try.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f9094ef74bf3
Comment 14 Ed Morley [:emorley] 2012-08-21 06:29:30 PDT
https://hg.mozilla.org/mozilla-central/rev/f9094ef74bf3

Note You need to log in before you can comment on or make changes to this bug.