Fix PluginInstanceParent.cpp build with GCC 4.6

RESOLVED FIXED in mozilla17

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla17
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 650573 [details] [diff] [review]
fix the build

On Ubuntu 12.04, gcc 4.6.3, I get this build error:

/hack/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp: In member function ‘virtual bool mozilla::plugins::PluginInstanceParent::AnswerNPN_SetValue_NPPVpluginDrawingModel(const int&, mozilla::plugins::PPluginInstanceParent::OptionalShmem*, mozilla::plugins::PPluginInstanceParent::CrossProcessMutexHandle*, NPError*)’:
/hack/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:453:46: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
cc1plus: all warnings being treated as errors

WARNINGS_AS_ERRORS has been enabled there by bug 743573.

The code here sucks: there is no valid use case for converting integers of smaller sizes to pointers. If a universal untyped storage of the size of a pointer is wanted, void* is not the right type to use for that. uintptr_t would be it.

hg annotate is unable to find the author of this code, as it hits a big merge first, 17c65d32c7b891e70435561b965b71c355bd28ac, by BenWa. CC'ing.
Attachment #650573 - Flags: review?(mounir)
Comment on attachment 650573 [details] [diff] [review]
fix the build

I don't understand the second paragraph of your rant; we're dealing with a frozen NPAPI call here which specifies a void* and then sometimes passes numbers through it. We should just make the cast and not fret.
Attachment #650573 - Flags: review?(mounir) → review+
(Assignee)

Comment 2

5 years ago
If the NPAPI interface requires that void*, I shall direct my ranting against NPAPI instead of the author of this code.
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/c69b5af20a85
Assignee: nobody → bjacob
Target Milestone: --- → mozilla17
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/28a61955e49c

backed out from inbound because Ms2ger landed a fix on m-c.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 781058
(Assignee)

Comment 5

5 years ago
hah! That was a _different_ occurence in the same file. Re-landed.
http://hg.mozilla.org/integration/mozilla-inbound/rev/2adcd3434404
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(Assignee)

Updated

5 years ago
Duplicate of this bug: 781058
https://hg.mozilla.org/mozilla-central/rev/2adcd3434404
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.