781545 - Fix PluginInstanceParent.cpp build with GCC 4.6

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fix the build

On Ubuntu 12.04, gcc 4.6.3, I get this build error:

/hack/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp: In member function ‘virtual bool mozilla::plugins::PluginInstanceParent::AnswerNPN_SetValue_NPPVpluginDrawingModel(const int&, mozilla::plugins::PPluginInstanceParent::OptionalShmem*, mozilla::plugins::PPluginInstanceParent::CrossProcessMutexHandle*, NPError*)’:
/hack/mozilla-central/dom/plugins/ipc/PluginInstanceParent.cpp:453:46: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
cc1plus: all warnings being treated as errors

WARNINGS_AS_ERRORS has been enabled there by bug 743573.

The code here sucks: there is no valid use case for converting integers of smaller sizes to pointers. If a universal untyped storage of the size of a pointer is wanted, void* is not the right type to use for that. uintptr_t would be it.

hg annotate is unable to find the author of this code, as it hits a big merge first, 17c65d32c7b891e70435561b965b71c355bd28ac, by BenWa. CC'ing.

Comment 1

[Benjamin Smedberg]

Comment on attachment 650573 [details] [diff] [review]
fix the build

I don't understand the second paragraph of your rant; we're dealing with a frozen NPAPI call here which specifies a void* and then sometimes passes numbers through it. We should just make the cast and not fret.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

If the NPAPI interface requires that void*, I shall direct my ranting against NPAPI instead of the author of this code.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c69b5af20a85

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/28a61955e49c

backed out from inbound because Ms2ger landed a fix on m-c.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

hah! That was a _different_ occurence in the same file. Re-landed.
http://hg.mozilla.org/integration/mozilla-inbound/rev/2adcd3434404

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2adcd3434404