Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Build warnings in dom/

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 613186 [details] [diff] [review]
Patch v1
Attachment #613186 - Flags: review?(mounir)
Comment on attachment 613186 [details] [diff] [review]
Patch v1

Review of attachment 613186 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsDOMClassInfo.cpp
@@ +8795,5 @@
>    }
>  
> +  nsHTMLDocument* doc = GetDocument(obj);
> +  nsISupports* result = NULL;
> +  nsWrapperCache* cache = NULL;

Could you use nsnull instead?

::: dom/plugins/ipc/PluginModuleParent.cpp
@@ +585,5 @@
>  
>  PluginIdentifierParent*
>  PluginModuleParent::GetIdentifierForNPIdentifier(NPP npp, NPIdentifier aIdentifier)
>  {
> +    PluginIdentifierParent* ident = NULL;

nsnull?
Attachment #613186 - Flags: review?(mounir) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 640633 [details] [diff] [review]
Patch v2

I don't remember what went wrong with the previous patch, but this passes try: <https://tbpl.mozilla.org/?tree=Try&rev=cc52db937c0f>.
Attachment #613186 - Attachment is obsolete: true
Attachment #640633 - Flags: review?(mounir)
Comment on attachment 640633 [details] [diff] [review]
Patch v2

Review of attachment 640633 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, I don't have cycles for that. Moving to khuey hoping he has some.
Attachment #640633 - Flags: review?(mounir) → review?(khuey)
(Assignee)

Comment 4

5 years ago
Created attachment 643349 [details] [diff] [review]
Patch v3
Attachment #640633 - Attachment is obsolete: true
Attachment #640633 - Flags: review?(khuey)
Attachment #643349 - Flags: review?(jonas)
(Assignee)

Comment 5

5 years ago
Created attachment 644953 [details] [diff] [review]
Patch v4
Attachment #643349 - Attachment is obsolete: true
Attachment #643349 - Flags: review?(jonas)
Attachment #644953 - Flags: review?(jonas)
(Assignee)

Comment 6

5 years ago
Created attachment 648484 [details] [diff] [review]
Patch v5
Attachment #644953 - Attachment is obsolete: true
Attachment #644953 - Flags: review?(jonas)
Attachment #648484 - Flags: review?(jonas)
Comment on attachment 648484 [details] [diff] [review]
Patch v5

Review of attachment 648484 [details] [diff] [review]:
-----------------------------------------------------------------

Does that make dom/ fully warning-free? If so, maybe we could add something in the Makfile rules that make dom/ subdirectories warning-free.
Attachment #648484 - Flags: review?(jonas) → review+
(Assignee)

Comment 8

5 years ago
Created attachment 649332 [details] [diff] [review]
More fixes

The static assertions are because of clang errors like:

../../../dom/indexedDB/OpenDatabaseHelper.cpp:27:1: error: unused function 'pr_static_assert' [-Werror,-Wunused-function]
PR_STATIC_ASSERT(JS_STRUCTURED_CLONE_VERSION == 1);
^
../../dist/include/prtypes.h:535:17: note: expanded from macro 'PR_STATIC_ASSERT'
    extern void pr_static_assert(int arg[(condition) ? 1 : -1])
                ^
1 error generated.
Attachment #649332 - Flags: review?(mounir)
Attachment #649332 - Flags: review?(mounir) → review+
(Assignee)

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/1bbc0b65dffb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Assignee)

Comment 10

5 years ago
And I pushed

https://hg.mozilla.org/integration/mozilla-inbound/rev/08b1e1a4b851

with fixes from Aryeh.
https://hg.mozilla.org/mozilla-central/rev/08b1e1a4b851
This is now causing 

dom/base/nsDOMClassInfo.cpp:9069:29: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]

Casting 32 bit int to void *: tsk, tsk...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is on a x86-64 bit linux system.  

I'm confused as to why the buildbots didn't catch this--do we not turn on warnings-as-errors there?
These too:

dom/plugins/base/nsPluginNativeWindowGtk2.cpp:202:147: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]

dom/plugins/ipc/PluginInstanceParent.cpp:409:48: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
Blocks: 781058
(Assignee)

Comment 15

5 years ago
I'll fix those in bug 781058.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Duplicate of this bug: 774975
Depends on: 781545
Depends on: 781686
Depends on: 827193
No longer depends on: 827193
(Assignee)

Updated

4 years ago
Duplicate of this bug: 728543
Blocks: 1068113
You need to log in before you can comment on or make changes to this bug.