Last Comment Bug 781708 - Log warnings about unexpected beginBatchEdit/endBatchEdit counts
: Log warnings about unexpected beginBatchEdit/endBatchEdit counts
Product: Firefox for Android
Classification: Client Software
Component: Keyboards and IME (show other bugs)
: Trunk
: ARM Android
-- normal (vote)
: Firefox 17
Assigned To: Chris Peterson [:cpeterson]
: Jim Chen [:jchen] [:darchons]
Depends on:
  Show dependency treegraph
Reported: 2012-08-09 18:23 PDT by Chris Peterson [:cpeterson]
Modified: 2012-08-15 18:47 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

log-batch-edit-count.patch (5.52 KB, patch)
2012-08-09 18:23 PDT, Chris Peterson [:cpeterson]
blassey.bugs: review+
Details | Diff | Splinter Review

Description User image Chris Peterson [:cpeterson] 2012-08-09 18:23:59 PDT
Created attachment 650746 [details] [diff] [review]

When debugging bug 781020, I saw that SwiftKey would call beginBatchEdit() multiple times before calling endBatchEdit() (a matching number of times). This surprised me, but seems legitimate.

This patch adds some extra DEBUG-only logging of BatchEdit calls without (AFAIK) changing the BatchEdit logic.

This patch also adds a Log.w() warning visible to users (or third-party IME developers :) if endBatchEdit() is called too many times. I haven't seen this happen, but I can imagine some IMEs getting confused when Gecko blows away the BatchEdit count.
Comment 1 User image Chris Peterson [:cpeterson] 2012-08-15 05:58:39 PDT
Comment 2 User image Ryan VanderMeulen [:RyanVM] 2012-08-15 18:47:04 PDT

Note You need to log in before you can comment on or make changes to this bug.