Closed
Bug 781708
Opened 12 years ago
Closed 12 years ago
Log warnings about unexpected beginBatchEdit/endBatchEdit counts
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(firefox17 fixed)
RESOLVED
FIXED
Firefox 17
| Tracking | Status | |
|---|---|---|
| firefox17 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(1 file)
|
5.52 KB,
patch
|
blassey
:
review+
|
Details | Diff | Splinter Review |
When debugging bug 781020, I saw that SwiftKey would call beginBatchEdit() multiple times before calling endBatchEdit() (a matching number of times). This surprised me, but seems legitimate. This patch adds some extra DEBUG-only logging of BatchEdit calls without (AFAIK) changing the BatchEdit logic. This patch also adds a Log.w() warning visible to users (or third-party IME developers :) if endBatchEdit() is called too many times. I haven't seen this happen, but I can imagine some IMEs getting confused when Gecko blows away the BatchEdit count.
Attachment #650746 -
Flags: review?(blassey.bugs)
|
||
Updated•12 years ago
|
Attachment #650746 -
Flags: review?(blassey.bugs) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75e7e41c1437
status-firefox17:
--- → fixed
|
||
Comment 2•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75e7e41c1437
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•