The default bug view has changed. See this FAQ.

Log warnings about unexpected beginBatchEdit/endBatchEdit counts

RESOLVED FIXED in Firefox 17

Status

()

Firefox for Android
Keyboards and IME
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
Firefox 17
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 650746 [details] [diff] [review]
log-batch-edit-count.patch

When debugging bug 781020, I saw that SwiftKey would call beginBatchEdit() multiple times before calling endBatchEdit() (a matching number of times). This surprised me, but seems legitimate.

This patch adds some extra DEBUG-only logging of BatchEdit calls without (AFAIK) changing the BatchEdit logic.

This patch also adds a Log.w() warning visible to users (or third-party IME developers :) if endBatchEdit() is called too many times. I haven't seen this happen, but I can imagine some IMEs getting confused when Gecko blows away the BatchEdit count.
Attachment #650746 - Flags: review?(blassey.bugs)
Attachment #650746 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/75e7e41c1437
status-firefox17: --- → fixed
https://hg.mozilla.org/mozilla-central/rev/75e7e41c1437
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.