Comment 1 Treeherder Robot 2012-09-23 11:27:42 PDT

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=15459716&tree=Firefox
Rev3 Fedora 12 mozilla-central opt test xpcshell on 2012-09-23 10:25:57
slave: talos-r3-fed-036

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_history_tracker.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/head.js | TypeError: tracker._lazySave is null - See following stack:

Comment 2 :Benjamin Peterson 2012-09-23 11:36:33 PDT

Created attachment 663835 [details] [diff] [review]
check for null

Comment 3 Philipp von Weitershausen [:philikon] 2012-09-23 11:40:48 PDT

Comment on attachment 663835 [details] [diff] [review]
check for null

403 gps :)

Comment 4 :Benjamin Peterson 2012-09-23 11:53:17 PDT

(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> Comment on attachment 663835 [details] [diff] [review]
> check for null
> 
> 403 gps :)

You mean 303? :)

Comment 5 Philipp von Weitershausen [:philikon] 2012-09-23 12:01:50 PDT

(In reply to Benjamin Peterson [:benjamin] from comment #4)
> (In reply to Philipp von Weitershausen [:philikon] from comment #3)
> > Comment on attachment 663835 [details] [diff] [review]
> > check for null
> > 
> > 403 gps :)
> 
> You mean 303? :)

I meant 302... off-by-one error in the left hand :/

Comment 6 Gregory Szorc [:gps] 2012-09-24 13:59:14 PDT

Comment on attachment 663835 [details] [diff] [review]
check for null

Review of attachment 663835 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for some improper English in the commit message. s/its/it's/ and s/their/there/.

There's a few other tests also not conditionally checking for _lazySave. I guess we're just lucky and don't have errors elsewhere. If you would be so kind to do a follow-up patch to address these other instances, it would be appreciated. I may even favor a "destructor" API on tracker. If you don't want to do it, no worries.

Comment 7 :Benjamin Peterson 2012-09-24 14:04:13 PDT

(In reply to Gregory Szorc [:gps] from comment #6)
> Comment on attachment 663835 [details] [diff] [review]
> check for null
> 
> Review of attachment 663835 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good except for some improper English in the commit message.
> s/its/it's/ and s/their/there/.
> 
> There's a few other tests also not conditionally checking for _lazySave. I
> guess we're just lucky and don't have errors elsewhere. If you would be so
> kind to do a follow-up patch to address these other instances, it would be
> appreciated. I may even favor a "destructor" API on tracker. If you don't
> want to do it, no worries.

I looked a most of those. I think they're mostly okay, though, because they call saveChangedIDs immediately beforehand. saveChangedIDs actually creates the timer.

Comment 8 :Benjamin Peterson 2012-09-24 14:07:30 PDT

https://hg.mozilla.org/integration/mozilla-inbound/rev/426fd9c73834

Comment 9 Ed Morley [:emorley] 2012-09-25 06:20:21 PDT

https://hg.mozilla.org/mozilla-central/rev/426fd9c73834

Comment 10 Ed Morley [:emorley] 2012-10-01 05:38:16 PDT

https://hg.mozilla.org/releases/mozilla-aurora/rev/a6656f7e9917