Closed Bug 782272 Opened 7 years ago Closed 7 years ago

Intermittent test_history_tracker.js | test failed (with xpcshell return code: 0) | head.js| TypeError: tracker._lazySave is null

Categories

(Core Graveyard :: Web Services, defect)

x86
Windows 7
defect
Not set

Tracking

(firefox17 fixed)

RESOLVED FIXED
mozilla18
Tracking Status
firefox17 --- fixed

People

(Reporter: emorley, Assigned: Benjamin)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Rev3 WINNT 6.1 mozilla-inbound debug test xpcshell on 2012-08-12 23:12:19 PDT for push 9e0799cf1096

slave: talos-r3-w7-059

https://tbpl.mozilla.org/php/getParsedLog.php?id=14333822&tree=Mozilla-Inbound

{
TEST-INFO | c:/talos-slave/test/build/xpcshell/tests/services/sync/tests/unit/test_history_tracker.js | Starting cleanup
Clean up.

TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\head.js | TypeError: tracker._lazySave is null - See following stack:
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: do_throw :: line 451
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: _run_next_test :: line 899
JS frame :: c:\talos-slave\test\build\xpcshell\head.js :: <TOP_LEVEL> :: line 418
}
Attached patch check for nullSplinter Review
Assignee: nobody → benjamin
Attachment #663835 - Flags: review?(philipp)
Comment on attachment 663835 [details] [diff] [review]
check for null

403 gps :)
Attachment #663835 - Flags: review?(philipp) → review?(gps)
(In reply to Philipp von Weitershausen [:philikon] from comment #3)
> Comment on attachment 663835 [details] [diff] [review]
> check for null
> 
> 403 gps :)

You mean 303? :)
(In reply to Benjamin Peterson [:benjamin] from comment #4)
> (In reply to Philipp von Weitershausen [:philikon] from comment #3)
> > Comment on attachment 663835 [details] [diff] [review]
> > check for null
> > 
> > 403 gps :)
> 
> You mean 303? :)

I meant 302... off-by-one error in the left hand :/
Comment on attachment 663835 [details] [diff] [review]
check for null

Review of attachment 663835 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for some improper English in the commit message. s/its/it's/ and s/their/there/.

There's a few other tests also not conditionally checking for _lazySave. I guess we're just lucky and don't have errors elsewhere. If you would be so kind to do a follow-up patch to address these other instances, it would be appreciated. I may even favor a "destructor" API on tracker. If you don't want to do it, no worries.
Attachment #663835 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #6)
> Comment on attachment 663835 [details] [diff] [review]
> check for null
> 
> Review of attachment 663835 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good except for some improper English in the commit message.
> s/its/it's/ and s/their/there/.
> 
> There's a few other tests also not conditionally checking for _lazySave. I
> guess we're just lucky and don't have errors elsewhere. If you would be so
> kind to do a follow-up patch to address these other instances, it would be
> appreciated. I may even favor a "destructor" API on tracker. If you don't
> want to do it, no worries.

I looked a most of those. I think they're mostly okay, though, because they call saveChangedIDs immediately beforehand. saveChangedIDs actually creates the timer.
https://hg.mozilla.org/mozilla-central/rev/426fd9c73834
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Whiteboard: [orange]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.