Status
()
People
(Reporter: emorley, Assigned: emorley)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 1 obsolete attachment)
3.08 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
Broken out from bug 781789: (In reply to Doug Turner (:dougt) from bug 781789 comment #6) > we should really disable all devicestorage tests on android.
(Assignee) | ||
Comment 1•7 years ago
|
||
Doug, did you mean dom/devicestorage/test/* or dom/devicestorage/* (and thus the ipc directory as well)?
Comment 2•7 years ago
|
||
sorry ed - yes, disable the tests in dom/devicestorage/*
(Assignee) | ||
Comment 3•7 years ago
|
||
Created attachment 651426 [details] [diff] [review] Disable on Android
Comment 4•7 years ago
|
||
Comment on attachment 651426 [details] [diff] [review] Disable on Android I think... you can also remove these lines from that file: 176 "dom/devicestorage/ipc/test_ipc.html": "", 177 "dom/devicestorage/test/test_basic.html": "", 178 "dom/devicestorage/test/test_dotdot.html": "", 179 "dom/devicestorage/test/test_enumerate.html": "", 180 "dom/devicestorage/test/test_enumerateMultipleContinue.html": "", 181 "dom/devicestorage/test/test_enumerateOptions.html": "", 182 "dom/devicestorage/test/test_lastModificationFilter.html": "", 183 "dom/devicestorage/test/test_overwrite.html": "", 184 "dom/devicestorage/test/test_sanity.html": "",
Attachment #651426 -
Flags: review?(doug.turner) → review-
(Assignee) | ||
Comment 5•7 years ago
|
||
Created attachment 651455 [details] [diff] [review] Disable on Android v2 Ah yes they can be taken out too. I hadn't looked that far down in the file since the listing are supposed to be alphabetical, but those entries date from before devicestorage moved locations in the tree.
Attachment #651426 -
Attachment is obsolete: true
Attachment #651455 -
Flags: review?(doug.turner)
Updated•7 years ago
|
Attachment #651455 -
Flags: review?(doug.turner) → review+
(Assignee) | ||
Comment 6•7 years ago
|
||
Thanks :-) https://hg.mozilla.org/integration/mozilla-inbound/rev/cdb3c9eb8070
Target Milestone: --- → mozilla17
(Assignee) | ||
Comment 7•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cdb3c9eb8070
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•