Closed Bug 782275 Opened 9 years ago Closed 9 years ago

Disable devicestorage tests on Android

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file, 1 obsolete file)

Disable on Android v2
3.08 KB, patch
dougt
: review+
Details | Diff | Splinter Review 
Broken out from bug 781789:

 (In reply to Doug Turner (:dougt) from bug 781789 comment #6)
> we should really disable all devicestorage tests on android.
Depends on: 781789
Doug, did you mean dom/devicestorage/test/* or dom/devicestorage/* (and thus the ipc directory as well)?
sorry ed - yes, disable the tests in dom/devicestorage/*
Attached patch Disable on Android (obsolete) — — Splinter Review
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #651426 - Flags: review?(doug.turner)
Comment on attachment 651426 [details] [diff] [review]
Disable on Android

I think... you can also remove these lines from that file:


176  "dom/devicestorage/ipc/test_ipc.html": "",
177  "dom/devicestorage/test/test_basic.html": "",
178  "dom/devicestorage/test/test_dotdot.html": "",
179  "dom/devicestorage/test/test_enumerate.html": "",
180  "dom/devicestorage/test/test_enumerateMultipleContinue.html": "",
181  "dom/devicestorage/test/test_enumerateOptions.html": "",
182  "dom/devicestorage/test/test_lastModificationFilter.html": "",
183  "dom/devicestorage/test/test_overwrite.html": "",
184  "dom/devicestorage/test/test_sanity.html": "",
Attachment #651426 - Flags: review?(doug.turner) → review-
Ah yes they can be taken out too.

I hadn't looked that far down in the file since the listing are supposed to be alphabetical, but those entries date from before devicestorage moved locations in the tree.
Attachment #651426 - Attachment is obsolete: true
Attachment #651455 - Flags: review?(doug.turner)
Attachment #651455 - Flags: review?(doug.turner) → review+
Thanks :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdb3c9eb8070
Target Milestone: --- → mozilla17
https://hg.mozilla.org/mozilla-central/rev/cdb3c9eb8070
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.