Closed
Bug 782287
Opened 12 years ago
Closed 12 years ago
minor SocialService cleanup
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: Gavin, Assigned: Gavin)
Details
Attachments
(1 file)
3.17 KB,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
A couple of small changes: - move the initialization code into its own function to clearly delineate it from the lazy provider loading - lazy load the MozSocialAPI module, and only load it if social is enabled
Assignee | ||
Comment 1•12 years ago
|
||
Comment 2•12 years ago
|
||
Comment on attachment 651397 [details] [diff] [review] patch Review of attachment 651397 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/social/SocialService.jsm @@ +44,5 @@ > +} > + > +XPCOMUtils.defineLazyGetter(SocialServiceInternal, "providers", function () { > + // Initialize the service > + initService(); This comment is useless.
Attachment #651397 -
Flags: review?(adw) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Tough but fair! :) Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/227c29b3c0ee
Flags: in-testsuite-
Target Milestone: --- → Firefox 17
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/227c29b3c0ee
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•