782287 - minor SocialService cleanup

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

A couple of small changes:
- move the initialization code into its own function to clearly delineate it from the lazy provider loading
- lazy load the MozSocialAPI module, and only load it if social is enabled

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 651397 [details] [diff] [review]
patch

Review of attachment 651397 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/social/SocialService.jsm
@@ +44,5 @@
> +}
> +
> +XPCOMUtils.defineLazyGetter(SocialServiceInternal, "providers", function () {
> +  // Initialize the service
> +  initService();

This comment is useless.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Tough but fair! :) Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/227c29b3c0ee

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/227c29b3c0ee