minor SocialService cleanup

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

Trunk
Firefox 17
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

A couple of small changes:
- move the initialization code into its own function to clearly delineate it from the lazy provider loading
- lazy load the MozSocialAPI module, and only load it if social is enabled
Created attachment 651397 [details] [diff] [review]
patch
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #651397 - Flags: review?(adw)

Comment 2

5 years ago
Comment on attachment 651397 [details] [diff] [review]
patch

Review of attachment 651397 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/social/SocialService.jsm
@@ +44,5 @@
> +}
> +
> +XPCOMUtils.defineLazyGetter(SocialServiceInternal, "providers", function () {
> +  // Initialize the service
> +  initService();

This comment is useless.
Attachment #651397 - Flags: review?(adw) → review+
Tough but fair! :) Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/227c29b3c0ee
Flags: in-testsuite-
Target Milestone: --- → Firefox 17
https://hg.mozilla.org/mozilla-central/rev/227c29b3c0ee
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.