78239 - Ctrl-k will not delete blank lines

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: Linux 2001-04-30-08

STEPS TO REPRODUCE:
1)  Type the following in a <textarea>:

aa
bb
cc

2)  Put the caret right before the first b
3)  Hit Ctrl-k
4)  Hit Ctrl-k a second time

EXPECTED RESULTS:  Step 4 causes the blank line between "aa" and "cc" to be deleted

ACTUAL RESULTS: Step 4 has no effect.

This is sort of spun off of bug 77976

Comment 1

[Akkana Peck]

Accepting -- targeting for m1.0 but will try to find time sooner.  I'd like this
to work, too, and was bummed when it regressed.

Comment 2

[Akkana Peck]

Ah, I just ran across a comment I made long ago in bug 54452 explaining why this
regressed (there's a more serious bug, which I was able to work around by
regressing this).  Adding dependency.

Comment 3

[Akkana Peck]

*** Bug 88376 has been marked as a duplicate of this bug. ***

Comment 4

[Akkana Peck]

For some reason, in this case, after doing an extend-selection-to-end-of-line,
isCollapsed on the selection is false.  I haven't been able to ferret out what
is actually in the selection yet.  Perhaps it should do a check like "is only
whitespace" rather than "is collapsed" ...

Comment 5

[Akkana Peck]

Kin has a patch in bug 98018 which also cures this one.

Comment 6

[Syd Logan]

spam composer change

Comment 7

[Akkana Peck]

Handing over to Kin since he has the patch which fixes it.

Comment 8

[kinmoz]

Fix checked into TRUNK:

    mozilla/editor/base/nsEditor.cpp  revision 1.337

Fix checked into the MOZILLA_0_9_4_BRANCH:

    mozilla/editor/base/nsEditor.cpp   revision 1.336.2.1

Comment 9

[sujay]

verified.