Closed Bug 98018 Opened 23 years ago Closed 23 years ago

Impossible to delete text in textbox

Categories

(Core :: Layout: Form Controls, defect, P3)

Product:
Core
Component:
Layout: Form Controls
Platform:
x86
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: mail, Assigned: kinmoz)

References

(
URL
)

Details

(Whiteboard: PDT+, fixed on trunk and 0.9.4 branch)

Attachments

(1 file)

Patch Rev 1
1.14 KB, patch
kinmoz
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review
From Bugzilla Helper: User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.3+) Gecko/20010831 BuildID: 2001083103 Reproducible: Always Steps to Reproduce: 1. Go to bugzilla helper. 2. Scroll down to the "steps to reproduce" textbox. 3. Move caret to before "2." 4. Press delete key (not backspace key) several times. Actual Results: It's possible to delete the "2.", but it's impossible to delete the "3." (only using the delete key). Expected Results: self-evident I've tried to reproduce the already fixed bug 96718 and have found this new bug.
Confirming with 2001082909 w2k. I'm going to reopen bug 96604 *** This bug has been marked as a duplicate of 96604 ***
Status: UNCONFIRMED → RESOLVED
Closed: 23 years ago
Resolution: --- → DUPLICATE
This is not 96604. This is a totally different issue. Reopening. FWIW, I see the reporter's behaviour on Linux 2001083108.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirming on Linux 2001083108. This is a high-visibility bug.
OS: Windows 98 → All
Severity: normal → critical
Keywords: nsCatFood
Target Milestone: --- → mozilla0.9.4
This is an editor backend problem, in nsEditor::CreateTxnForDeleteInsertionPoint(), that's been there for a long time. I'll take this one, cc'ing jfrancis@netscape.com, Moving milestone to mozilla0.9.5
Assignee: rods → kin
Priority: -- → P3
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Attached patch Patch Rev 1 — — Splinter Review
I just attatched Patch Rev 1 that fixes the problem. It needs some lovin' from jfrancis to make sure I'm not missing some reason for the old code.
Status: NEW → ASSIGNED
Whiteboard: FIX IN HAND needs r= and sr=
Comment on attachment 48180 [details] [diff] [review] Patch Rev 1 Joe gave me an r=jfrancis@netscape.com
Attachment #48180 - Flags: review+
Cc sfraser@netscape.com for super review.
Whiteboard: FIX IN HAND needs r= and sr= → FIX IN HAND needs sr=
Blocks: 78239
Comment on attachment 48180 [details] [diff] [review] Patch Rev 1 Those PRBool() casts are pretty redundant, but sr=sfraser
Attachment #48180 - Flags: superreview+
FYI, I removed the PRBool() cast that was in the original code. Fix checked into TRUNK: mozilla/editor/base/nsEditor.cpp revision 1.337
Keywords: nsbranch
Whiteboard: FIX IN HAND needs sr= → FIX IN HAND, reviewed, fix checked into trunk, fix not on 0.9.2 and 0.9.4 branches
Marking nsbranch+
Keywords: nsbranch+
removed keyword nsbranch since it now has nsbranch+, per pdt mtg.
Keywords: nsbranch
FYI, just waiting for pdt+ so I can land this on the 0.9.4 branch. This is an extremely low-risk fix.
Whiteboard: FIX IN HAND, reviewed, fix checked into trunk, fix not on 0.9.2 and 0.9.4 branches → FIX IN HAND, reviewed, fixed on trunk, fix not on 0.9.2 and 0.9.4 branches
PDT+. Pls get it in by 3 am roday.
Whiteboard: FIX IN HAND, reviewed, fixed on trunk, fix not on 0.9.2 and 0.9.4 branches → PDT+,FIX IN HAND, reviewed, fixed on trunk, fix not on 0.9.2 and 0.9.4 branches
Fix checked into the MOZILLA_0_9_4_BRANCH: mozilla/editor/base/nsEditor.cpp revision 1.336.2.1
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Whiteboard: PDT+,FIX IN HAND, reviewed, fixed on trunk, fix not on 0.9.2 and 0.9.4 branches → PDT+, fixed on trunk and 0.9.4 branch
verified on buildID: 2001-09-19-09trunk and 2001-09-19-05-0.9.4 win2000
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: