missing error handling within @supports condition parsing

RESOLVED FIXED in mozilla17

Status

()

Core
CSS Parsing and Computation
P4
normal
RESOLVED FIXED
5 years ago
a month ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 1 bug, {css3})

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Florian showed me http://test.csswg.org/source/contributors/opera/submitted/css3-conditional/at-supports-030.html , which we fail.

(Some of his other tests that we fail probably aren't valid.)

I audited for missing SkipUntil calls, found one, and it fixed the test.

(At some point we should import Florian's tests to test this.)
(Assignee)

Comment 1

5 years ago
Created attachment 651520 [details] [diff] [review]
Add missing SkipUntil call in @supports parsing.  ()
Attachment #651520 - Flags: review?(cam)
Attachment #651520 - Flags: review?(cam) → review+
(In reply to David Baron [:dbaron] from comment #0)
> (At some point we should import Florian's tests to test this.)

I see layout/reftests/w3c-css/received/ looks like the place where importing test from csswg.org would go.  I guess we should wait until the tooling for automatic importing there is set up?
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b300b474c35e
https://hg.mozilla.org/integration/mozilla-inbound/rev/98df684d7a3a (imported tests)
Priority: -- → P4
https://hg.mozilla.org/mozilla-central/rev/b300b474c35e
https://hg.mozilla.org/mozilla-central/rev/98df684d7a3a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
(Assignee)

Updated

a month ago
Blocks: 1353219
You need to log in before you can comment on or make changes to this bug.