Last Comment Bug 782521 - pthread_setname_np's 3rd arg doesn't need const on NetBSD
: pthread_setname_np's 3rd arg doesn't need const on NetBSD
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: All NetBSD
: -- normal (vote)
: mozilla17
Assigned To: Jan Beich
:
Mentors:
Depends on: 752067
Blocks: bsdipc
  Show dependency treegraph
 
Reported: 2012-08-13 22:19 PDT by Jan Beich
Modified: 2012-08-16 06:17 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
cast away const (1.16 KB, patch)
2012-08-13 22:27 PDT, Jan Beich
cjones.bugs: review+
Details | Diff | Review

Description Jan Beich 2012-08-13 22:19:00 PDT

    
Comment 1 Jan Beich 2012-08-13 22:27:44 PDT
Created attachment 651634 [details] [diff] [review]
cast away const

ipc/chromium/src/base/platform_thread_posix.cc:89:3: error:
      no matching function for call to 'pthread_setname_np'
  pthread_setname_np(pthread_self(), "%s", name);
  ^~~~~~~~~~~~~~~~~~
/usr/include/pthread.h:130:1: note:
      candidate function not viable: no known conversion from 'const char *' to
      'void *' for 3rd argument; take the address of the argument with &
pthread_setname_np(pthread_t thread, const char *name, void *arg);
^
1 error generated.
Comment 2 Ryan VanderMeulen [:RyanVM] 2012-08-15 18:05:28 PDT
Trivial, landing without Try results.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e656eb16307
Comment 3 Ed Morley [:emorley] 2012-08-16 06:17:56 PDT
https://hg.mozilla.org/mozilla-central/rev/8e656eb16307

Note You need to log in before you can comment on or make changes to this bug.