pthread_setname_np's 3rd arg doesn't need const on NetBSD

RESOLVED FIXED in mozilla17

Status

()

Core
IPC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jan Beich, Assigned: Jan Beich)

Tracking

Trunk
mozilla17
All
NetBSD
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 651634 [details] [diff] [review]
cast away const

ipc/chromium/src/base/platform_thread_posix.cc:89:3: error:
      no matching function for call to 'pthread_setname_np'
  pthread_setname_np(pthread_self(), "%s", name);
  ^~~~~~~~~~~~~~~~~~
/usr/include/pthread.h:130:1: note:
      candidate function not viable: no known conversion from 'const char *' to
      'void *' for 3rd argument; take the address of the argument with &
pthread_setname_np(pthread_t thread, const char *name, void *arg);
^
1 error generated.
Attachment #651634 - Flags: review?(jones.chris.g)
(Assignee)

Updated

5 years ago
Blocks: 753046
Depends on: 752067
Attachment #651634 - Flags: review?(jones.chris.g) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Trivial, landing without Try results.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e656eb16307
Assignee: nobody → jbeich
Flags: in-testsuite-
Keywords: checkin-needed

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/8e656eb16307
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.