Closed Bug 782521 Opened 7 years ago Closed 7 years ago

pthread_setname_np's 3rd arg doesn't need const on NetBSD

Categories

(Core :: IPC, defect)

All
NetBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

No description provided.
Attached patch cast away constSplinter Review
ipc/chromium/src/base/platform_thread_posix.cc:89:3: error:
      no matching function for call to 'pthread_setname_np'
  pthread_setname_np(pthread_self(), "%s", name);
  ^~~~~~~~~~~~~~~~~~
/usr/include/pthread.h:130:1: note:
      candidate function not viable: no known conversion from 'const char *' to
      'void *' for 3rd argument; take the address of the argument with &
pthread_setname_np(pthread_t thread, const char *name, void *arg);
^
1 error generated.
Attachment #651634 - Flags: review?(jones.chris.g)
Blocks: bsdipc
Depends on: 752067
Attachment #651634 - Flags: review?(jones.chris.g) → review+
Keywords: checkin-needed
Trivial, landing without Try results.

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e656eb16307
Assignee: nobody → jbeich
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8e656eb16307
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.