per-platform chat window icons

RESOLVED FIXED in Firefox 17

Status

()

Firefox
SocialAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

17 Branch
Firefox 18
Points:
---

Firefox Tracking Flags

(firefox17 fixed)

Details

(Whiteboard: [Fx17])

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
we need a minimize/maximize icon, and a close icon for the chat window.  Right now we're just grabbing some preexisting icons from the themes.
Assignee: nobody → jboriss
Created attachment 656729 [details]
Mockup: Chat window on OSX and Windows in read and unread

Attached are a mockup and the image files for chat window default colors on OSX and on Windows.  The first version won’t include the pop_out icon, but I’m attaching it to this bug for future use.  Clicking on the titlebar collapses the window.
Created attachment 656731 [details]
Icons: OSX & Windows chat controls on default, hover, click states
(Assignee)

Comment 3

5 years ago
taking this to create the patch
Assignee: jboriss → mixedpuppy
(Assignee)

Comment 4

5 years ago
Created attachment 657442 [details] [diff] [review]
chat style.patch

adds close icons and colors for all platforms.  needs verification on linux.
Attachment #657442 - Flags: review?(gavin.sharp)
(Assignee)

Updated

5 years ago
Blocks: 783687
Attachment #657442 - Flags: review?(gavin.sharp) → review?(jaws)
Comment on attachment 657442 [details] [diff] [review]
chat style.patch

Review of attachment 657442 [details] [diff] [review]:
-----------------------------------------------------------------

Please make the chat_close, chat_close_onclick, and chat_close_onhover all part of one image sprite. Using CSS to switch the current image like this when they reside in different files can show a flicker during the transition.

::: browser/themes/gnomestripe/browser.css
@@ +2748,5 @@
>    font-weight: bold;
>    color: -moz-dialogtext;
>  }
>  
>  .chat-titlebar {

Please add |cursor: pointer;| for the titlebar now that it will toggle the minimized/restored state and help with discoverability.

@@ +2763,5 @@
>  .chat-titlebar[minimized="true"] {
>    border-bottom: none;
>  }
>  
> +.chat-titlebar[selected="true"] {

.chat-titlebar[selected] since we never have a non-"true" value for the attribute.
Attachment #657442 - Flags: review?(jaws) → review-
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → 17 Branch
(Assignee)

Comment 6

5 years ago
Created attachment 658243 [details] [diff] [review]
chat style.patch
Attachment #657442 - Attachment is obsolete: true
Attachment #658243 - Flags: review?(jaws)
Attachment #658243 - Flags: review?(jaws) → review+
Comment on attachment 658243 [details] [diff] [review]
chat style.patch

>--- a/browser/themes/winstripe/jar.mn
>+++ b/browser/themes/winstripe/jar.mn
>@@ -99,16 +99,17 @@ browser.jar:
>         skin/classic/browser/preferences/Options-sync.png            (preferences/Options-sync.png)
> #endif
>         skin/classic/browser/preferences/saveFile.png                (preferences/saveFile.png)
> *       skin/classic/browser/preferences/preferences.css             (preferences/preferences.css)
>         skin/classic/browser/preferences/in-content/preferences.css  (preferences/in-content/preferences.css)
>         skin/classic/browser/preferences/applications.css            (preferences/applications.css)
>         skin/classic/browser/preferences/aboutPermissions.css        (preferences/aboutPermissions.css)
>         skin/classic/browser/social/social.png                       (social/social.png)
>+        skin/classic/browser/social/chat_close.png                   (social/chat_close.png)
>         skin/classic/browser/tabbrowser/alltabs.png                  (tabbrowser/alltabs.png)
>         skin/classic/browser/tabbrowser/newtab.png                   (tabbrowser/newtab.png)
>         skin/classic/browser/tabbrowser/newtab-inverted.png          (tabbrowser/newtab-inverted.png)
>         skin/classic/browser/tabbrowser/connecting.png               (tabbrowser/connecting.png)
>         skin/classic/browser/tabbrowser/loading.png                  (tabbrowser/loading.png)
>         skin/classic/browser/tabbrowser/tab.png                      (tabbrowser/tab.png)
>         skin/classic/browser/tabbrowser/tab-arrow-left.png           (tabbrowser/tab-arrow-left.png)
>         skin/classic/browser/tabbrowser/tab-arrow-left-inverted.png  (tabbrowser/tab-arrow-left-inverted.png)

You forgot adding this to the aero section.
Attachment #658243 - Flags: review-
yeah I noticed that before pushing and added it to the patch. Also changed the file name to chat-close.png (using the dash) to follow the convention

https://hg.mozilla.org/integration/mozilla-inbound/rev/d3c66f475f33
(Assignee)

Comment 9

5 years ago
Comment on attachment 658243 [details] [diff] [review]
chat style.patch

[Approval Request Comment]
status and flyout panel appearance needs to match the ux design.  the correct patch is in comment #8, which was modified to add aero styles
Attachment #658243 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 10

5 years ago
(In reply to Shane Caraveo (:mixedpuppy) from comment #9)
> Comment on attachment 658243 [details] [diff] [review]
> chat style.patch
> 
> [Approval Request Comment]
> status and flyout panel appearance needs to match the ux design.  the
> correct patch is in comment #8, which was modified to add aero styles

make that, chat icons :(  but also correcting to match ux design
Fwiw, usually the nomination for branch uplift comes after the patch has landed on trunk and ben resolved fixed (ideally, verified). Will come back to check on this at another time.
https://hg.mozilla.org/mozilla-central/rev/d3c66f475f33
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 18
Can you attach the landed patch for approval, so that I don't have to a+ an r-ed patch?
Created attachment 659724 [details] [diff] [review]
Landed patch
Attachment #658243 - Flags: approval-mozilla-aurora?
Attachment #659724 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/53f2c795e802
status-firefox17: --- → fixed
You need to log in before you can comment on or make changes to this bug.