Remove unnecessary returns from media mochitest event handlers

RESOLVED FIXED in mozilla17

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

Trunk
mozilla17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
A bunch of our tests "return false" from the handler, but it's unnecessary since our events aren't bubbling (since bug 608630) or cancellable (since bug 770945).

Also removes a couple of tests for completed variables that are declared false and never set to true.

Deletes 70 lines.  Green locally, pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=9b44c69194fc
(Assignee)

Comment 1

5 years ago
Created attachment 651995 [details] [diff] [review]
patch v0
Attachment #651995 - Flags: review?(chris.double)
(Assignee)

Updated

5 years ago
Depends on: 770945

Updated

5 years ago
Attachment #651995 - Flags: review?(chris.double) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/61c03f309b98

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/61c03f309b98
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.