Closed Bug 782876 Opened 8 years ago Closed 8 years ago

Remove unnecessary returns from media mochitest event handlers

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

A bunch of our tests "return false" from the handler, but it's unnecessary since our events aren't bubbling (since bug 608630) or cancellable (since bug 770945).

Also removes a couple of tests for completed variables that are declared false and never set to true.

Deletes 70 lines.  Green locally, pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=9b44c69194fc
Attached patch patch v0Splinter Review
Attachment #651995 - Flags: review?(chris.double)
Depends on: 770945
Attachment #651995 - Flags: review?(chris.double) → review+
https://hg.mozilla.org/mozilla-central/rev/61c03f309b98
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.