Closed
Bug 782876
Opened 13 years ago
Closed 13 years ago
Remove unnecessary returns from media mochitest event handlers
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: kinetik, Assigned: kinetik)
References
Details
Attachments
(1 file)
|
19.42 KB,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
A bunch of our tests "return false" from the handler, but it's unnecessary since our events aren't bubbling (since bug 608630) or cancellable (since bug 770945).
Also removes a couple of tests for completed variables that are declared false and never set to true.
Deletes 70 lines. Green locally, pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=9b44c69194fc
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #651995 -
Flags: review?(chris.double)
|
||
Updated•13 years ago
|
Attachment #651995 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•