78289 - Crash saving as draft with no draft folder

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[scottputterman]

Using 2001043004 on Win 2000

Set your drafts folder for whatever account you are using to not have a folder
(mine was a news account).
Create a New Message from that account.
Hit the save button and crash.

Unfortunately I didn't get a trace with symbols.  Here's the top of the stack
with incident ID 29837073:

necko.dll + 0x6325 (0x60776325) 
msgcompo.dll + 0x207f3 (0x606707f3) 
msgcompo.dll + 0x171d3 (0x606671d3) 
msgcompo.dll + 0x16f59 (0x60666f59) 
msgcompo.dll + 0x16f84 (0x60666f84) 
msgcompo.dll + 0xd0f6 (0x6065d0f6) 
msgcompo.dll + 0x15443 (0x60665443) 
msgcompo.dll + 0x7758 (0x60657758) 
msgcompo.dll + 0x91bc (0x606591bc) 
msgcompo.dll + 0x16e12 (0x60666e12) 
msgcompo.dll + 0xb551 (0x6065b551) 
msgcompo.dll + 0x111e0 (0x606611e0) 
xpcom.dll + 0x50b7 (0x60eb50b7)

Comment 1

[scottputterman]

marking nsbeta1+ and reassigning to cavin since he's been working on some save
as drafts bugs.

Comment 2

[esther]

Interesting,  because of Jaime's problem on Friday, I tried to send a copy of a
draft and a copy of a template to my IMAP account with no Drafts or Templates
folder. I did not crash, it went into a infinite try to copy, but when I
manually closed the failed New Msg window, it gave me a error stating it hadn't
completed the task, did I really want to close it.  I said yes and checked to
see if I could successfully send, everything was OK.  Were you saving to a
missing local or imap drafts folder?

Comment 3

[scottputterman]

I was in a newsgroup and both templates and drafts said "Please choose a folder"
Until I chose the folder, it crashed.

Comment 4

[scottputterman]

Cavin asked me how to get into this state.  I don't know.  For some reason all
of my news accounts have their drafts and templates set to "Please Choose a
folder".  Is this even possible now or is this a remnant of an old profile? 
cc'ing sspitzer, racham, and ducarroz.

Comment 5

[esther]

I was going to ask that too.  After checking your comments last night, I
couldn't figure out how to get into that state.  I know I saw this state months
ago, it was a bug but I don't know how to get to it now.  I'll try a few things
to see if we can reproduce the state.

Comment 6

[varada]

The last time that happened was because the pref values were not being reflected
in the GUI- I would suggest changing the values in the prefs.js

Comment 7

[scottputterman]

So, all of my news accounts are like this.  But if I'm a rare case this bug
isn't as important.  

Comment 8

[Cavin Song]

Manually edit prefs.jf file like the following does do the trick:

  user_pref("mail.identity.id2.draft_folder", "");

I tried to point the draft folder to a folder in the already removed account 
but the program handles it correctly for this scenario.

Comment 9

[Cavin Song]

Attachment: Fixed crashes.

Comment 10

[(not reading, please use [e-mail] instead)]

no go on this patch.

there's a big bug about nsStdUrl.cpp not handling null schemes.

(valeski or gagan own it, I think.)

until it is fixed, the necko module owners will not take this patch.

instead, you are going to have to fix the caller (compose in this case) to not 
call into necko if the scheme is null.

read http://bugzilla.mozilla.org/show_bug.cgi?id=76200 for a similar issue,
a similar fix was proposed, and rejected.  so we fixed the caller instead.

Comment 11

[(not reading, please use [e-mail] instead)]

update, cavin is working on a different fix.

he's going to fix the nsMsgIdentity so that getFolderPref() will return the
proper default pref if the current value is empty.

Comment 12

[Cavin Song]

Attachment: getFolderPref() now handles default folders.

Comment 13

[(not reading, please use [e-mail] instead)]

building and testing now.  it all looks good, except you need to use
PR_FREEIF() instead of CRTFREEIF().

the string is allocated with PL_strdup(), see prefapi.c

if testing goes well, I hope to land when the tree opens.

Comment 14

[(not reading, please use [e-mail] instead)]

fixed.

Comment 15

[esther]

Using build 2001-05-08 on win, mac and linux I verified this by changing the 
prefs.js file to have my drafts pointing to "".  When I launched, and opened 
mail we automatically it defaulted to my local drafts, which is the fix for this 
bug.  Verified.