782890 - BrowserNewTabPreloader.jsm and SafeBrowsing.jsm are referenced using the wrong URI

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[ojab]

I'm using Fx from mozilla-inbound and after Bug 753448 (exactly -r102295:a5b58ae99ac9) fixed 'New Tab' button opens new tab, but doesn't switch to it.

I should mention that I'm using firefox from objdir without actually installing it, so I have 'mk_add_options MOZ_OBJDIR=/home/ojab/opt' in mozconfig and running Fx with `~/opt/browser/dist/bin/firefox`.

I've found that there is two errors in 'Error Console':

Timestamp: 15.08.2012 11:50:04
Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
Source File: chrome://browser/content/browser.js
Line: 153

Timestamp: 15.08.2012 11:50:06
Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
Source File: chrome://browser/content/browser.js
Line: 146


which are "resource://gre/modules/BrowserNewTabPreloader.jsm" and "resource://gre/modules/SafeBrowsing.jsm", which are resides only in /home/ojab/opt/browser/dist/bin/modules/.

I've looked on PluralForm.jsm as an other example of file in resource://gre/modules/ and it resides in /home/ojab/opt/xulrunner/dist/bin/modules/PluralForm.jsm and /home/ojab/opt/browser/dist/bin/xulrunner/modules/PluralForm.jsm, so I've copied BrowserNewTabPreloader.jsm and SafeBrowsing.jsm to /home/ojab/opt/browser/dist/bin/xulrunner/modules and 'New Tab' button works as expected even after I've deleting this files again (looks like it's cached somewhere in profile or something like that).

As a side note: I've had an issue with session restore (Bug 779107) related to SafeBrowsing.jsm not found, but it as fixed somehow (most likely when I've run official Nightly build for the test) and I haven't found the source.

So I think that BrowserNewTabPreloader.jsm and SafeBrowsing.jsm should actually be built in xulrunner, not in browser.

Comment 1

[Mike Hommey [:glandium]]

They should just be included with the right url.

Comment 2

[Mike Hommey [:glandium]]

Attachment: browser.js includes SafeBrowsing.jsm and BrowserNewTabPreloader.jsm with the wrong url

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c3fae3b9156

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c3fae3b9156

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8d3c569917d4

Comment 6

[ojab]

Sorry for the late test, looks like it isn't fixed (or was fixed, but broken again, unfortunately doesn't follow hg log closely).
After clean Fx rebuild (Built from http://hg.mozilla.org/integration/mozilla-inbound/rev/65cf1362d58c) Ctrl-T opens New Tab, but doesn't switch to it. In error console there is:

Timestamp: 21.09.2012 19:18:22
Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
Source File: resource://gre/modules/XPCOMUtils.jsm
Line: 222

after first Ctrl-T and

Timestamp: 21.09.2012 19:18:23
Error: ReferenceError: gBrowserNewTabPreloader is not defined
Source File: chrome://browser/content/tabbrowser.xml
Line: 1394

after next Ctrl-Ts.

strace shows 
lstat("/home/ojab/opt/browser/dist/bin/xulrunner/modules/BrowserNewTabPreloader.jsm", 0x7fffb4444fa0) = -1 ENOENT (No such file or directory)
stat("/home/ojab/opt/browser/dist/bin/xulrunner/modules/BrowserNewTabPreloader.jsm", 0x7fc4d57ae7d8) = -1 ENOENT (No such file or directory)
lstat("/home/ojab/opt/browser/dist/bin/xulrunner/modules/BrowserNewTabPreloader.jsm", 0x7fc4d57ae7d8) = -1 ENOENT (No such file or directory)

and after copying or even moving BrowserNewTabPreloader.jsm to his location (from /home/ojab/opt/browser/dist/bin/modules/BrowserNewTabPreloader.jsm after Fx build) Ctrl-T works fine.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Looks like http://hg.mozilla.org/mozilla-central/rev/90cc14017766 regressed this. Tim!

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

I'm sorry.

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Attachment: yet another patch

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/243f94de7936

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/243f94de7936

Comment 12

[ojab]

Can I haz fix in mozilla-inbound tree?
As a side note, what is the purpose of fx-team tree? I can't google anything useful.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

It's just another mozilla-central integration branch, like inbound. This'll make it to inbound eventually as the merges happen :)

Comment 14

[u279076]

ojab, can you please confirm this is fixed for you now?

Comment 15

[ojab]

Confirming, it's fixed.

Comment 16

[u279076]

Thanks ojab!

Comment 17

[Jim Mathies [:jimm]]

We need to undo this change now that bug 778608 has landed.

Comment 18

[Jim Mathies [:jimm]]

(In reply to Jim Mathies [:jimm] from comment #17)
> We need to undo this change now that bug 778608 has landed.

(For safe browsing only, I'll file a follow up)