783070 - Need to test building with local xulrunner

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Builder, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

bug 772681 has been resolved, making xulrunner available on celery machines. We need to test the ability to use xulrunner to package add-ons instead of the existing pythom implementation. 

Assigning to Alex for now, will need to coordinate next week with Alex & Piotr.

Comment 1

[Alexandre Poirot [:ochameau]]

Piotr, can you give it a try ?
You just need to use this SDK tarball:
  https://github.com/ochameau/addon-sdk/tarball/cfx.js
and eventually add "--binary /path/to/xulrunner-bin" if it doesn't work out of the box. (python tries to automatically find xulrunner bin by itself but it may fail)

Comment 2

[Piotr Zalewa [:zalun]]

this isn't a full SDK is it?
as I can't import it into the builder

Comment 3

[Alexandre Poirot [:ochameau]]

It is a full SDK tarball, but it lacks of some release stuff like version number.
It is like using github master.
I can try to generate a fake release tarball if it can help?

Comment 4

[Alexandre Poirot [:ochameau]]

So the only thing you have to do to have a correct version set is to modify
  /python-lib/cuddlefish/_version.py
And replace at line 12:
  git_refnames = " (cfx.js)"
by:
  git_refnames = " (HEAD, 1.10, origin/release, release)"

Comment 5

[Piotr Zalewa [:zalun]]

my git_refnames were different ... should I use a specific version of SDK?

  git_refnames = "$Format:%d$"

Comment 6

[Alexandre Poirot [:ochameau]]

I don't know it is up to you to please builder code/scripts to accept this SDK test tarball. I have no idea what are builder expectations.
What kind of issues are you having?

Comment 7

[Piotr Zalewa [:zalun]]

I believe there is no issue anymore ... Please reopen if in doubt