783103 - Avoid layout flush from isElementVisible when attempting to focus the URL bar or search bar

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

In which cases does isElementVisible(gURLBar) return false (assuming gURLBar is non-null)? Is that only when the url bar is on a hidden toolbar? Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?

Comment 2

[Dão Gottwald [:dao]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #1)
> In which cases does isElementVisible(gURLBar) return false (assuming gURLBar
> is non-null)? Is that only when the url bar is on a hidden toolbar?

That and in certain popups if dom.disable_window_open_feature.location is false.

> Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?

Yes. However, gURLBar.focused can report true if the URL bar was focused when it got hidden and the user hasn't manually focused something else (bug 570835).

Comment 3

[Neil Deakin]

Of course, I meant to change flag for my name, not Gavin's

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/caeb23f6d957

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/caeb23f6d957

Comment 6

[Octoploid]

This patch caused Bug 784621.