Avoid layout flush from isElementVisible when attempting to focus the URL bar or search bar

RESOLVED FIXED in Firefox 17

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({perf})

Trunk
Firefox 17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [snappy])

Attachments

(1 attachment)

2.03 KB, patch
Neil Deakin (not available until Aug 9)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Created attachment 652247 [details] [diff] [review]
patch
Attachment #652247 - Flags: review?(gavin.sharp)
In which cases does isElementVisible(gURLBar) return false (assuming gURLBar is non-null)? Is that only when the url bar is on a hidden toolbar? Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?
(Assignee)

Comment 2

5 years ago
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #1)
> In which cases does isElementVisible(gURLBar) return false (assuming gURLBar
> is non-null)? Is that only when the url bar is on a hidden toolbar?

That and in certain popups if dom.disable_window_open_feature.location is false.

> Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?

Yes. However, gURLBar.focused can report true if the URL bar was focused when it got hidden and the user hasn't manually focused something else (bug 570835).
(Assignee)

Updated

5 years ago
Keywords: perf
Whiteboard: [snappy]
(Assignee)

Updated

5 years ago
Attachment #652247 - Flags: review?(enndeakin)
Attachment #652247 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

5 years ago
Attachment #652247 - Flags: review?(enndeakin)
Of course, I meant to change flag for my name, not Gavin's
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/caeb23f6d957
https://hg.mozilla.org/mozilla-central/rev/caeb23f6d957
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17

Comment 6

5 years ago
This patch caused Bug 784621.
(Assignee)

Updated

5 years ago
Depends on: 784621
You need to log in before you can comment on or make changes to this bug.