Last Comment Bug 783103 - Avoid layout flush from isElementVisible when attempting to focus the URL bar or search bar
: Avoid layout flush from isElementVisible when attempting to focus the URL bar...
Status: RESOLVED FIXED
[snappy]
: perf
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal with 1 vote (vote)
: Firefox 17
Assigned To: Dão Gottwald [:dao]
:
:
Mentors:
Depends on: 784621
Blocks: 783064
  Show dependency treegraph
 
Reported: 2012-08-15 14:57 PDT by Dão Gottwald [:dao]
Modified: 2013-02-22 14:39 PST (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.03 KB, patch)
2012-08-15 14:57 PDT, Dão Gottwald [:dao]
enndeakin: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-08-15 14:57:07 PDT
Created attachment 652247 [details] [diff] [review]
patch
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-08-15 15:17:45 PDT
In which cases does isElementVisible(gURLBar) return false (assuming gURLBar is non-null)? Is that only when the url bar is on a hidden toolbar? Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?
Comment 2 Dão Gottwald [:dao] 2012-08-15 15:28:30 PDT
(In reply to :Gavin Sharp (use gavin@gavinsharp.com for email) from comment #1)
> In which cases does isElementVisible(gURLBar) return false (assuming gURLBar
> is non-null)? Is that only when the url bar is on a hidden toolbar?

That and in certain popups if dom.disable_window_open_feature.location is false.

> Is gURLBar.focus() always guaranteed to be a no-op in all of those cases?

Yes. However, gURLBar.focused can report true if the URL bar was focused when it got hidden and the user hasn't manually focused something else (bug 570835).
Comment 3 Neil Deakin (away until Oct 3) 2012-08-21 06:34:29 PDT
Of course, I meant to change flag for my name, not Gavin's
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-08-21 19:10:05 PDT
https://hg.mozilla.org/mozilla-central/rev/caeb23f6d957
Comment 6 Octoploid 2012-08-22 02:26:45 PDT
This patch caused Bug 784621.

Note You need to log in before you can comment on or make changes to this bug.