784621 - Empty address bar isn't always focused after startup

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Octoploid]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120822094317

Steps to reproduce:

Start Firefox


Actual results:

Address bas is not selected (no cursor).
Happens with about:blank and about:newtab.


Expected results:

The address bar should be selected by default.

Comment 1

[Octoploid]

Started with:

commit 5f387a38960ae207462848cf0f2bbf20775abfa5
Author: Dão Gottwald <[e-mail]>
Date:   Tue Aug 21 15:53:39 2012 +0200

    Bug 783103 - Avoid layout flush from isElementVisible when attempting to focus the URL bar or search bar. r=enn

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

I couldn't reproduce this bug with my default profiles on Windows and Linux, but I can reproduce it with a new profile on Linux. delayedStartup appears to be racing with the initial window being focused, and gURLBar.focused will only be true once the window is focused.

Comment 3

[Neil Deakin]

Comment on attachment 654180 [details] [diff] [review]
patch

Seems ok, as long as the extra call to mouseoverToggle and select() is acceptable.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Neil Deakin from comment #3)
> Comment on attachment 654180 [details] [diff] [review]
> patch
> 
> Seems ok, as long as the extra call to mouseoverToggle and select() is
> acceptable.

FullScreen.mouseoverToggle will only be called when starting up in fullscreen mode, and return early because the fullscreen UI isn't set up at that point. select() can be avoided if deemed worthwhile, see bug 783064 comment 1.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3ded80c6a2da

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3ded80c6a2da