Last Comment Bug 784621 - Empty address bar isn't always focused after startup
: Empty address bar isn't always focused after startup
Status: RESOLVED FIXED
: regression
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: 17 Branch
: x86_64 Linux
: -- normal with 1 vote (vote)
: Firefox 17
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on:
Blocks: 783103
  Show dependency treegraph
 
Reported: 2012-08-22 01:20 PDT by Octoploid
Modified: 2013-02-22 14:39 PST (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.83 KB, patch)
2012-08-22 05:25 PDT, Dão Gottwald [:dao]
enndeakin: review+
Details | Diff | Review

Description Octoploid 2012-08-22 01:20:49 PDT
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Firefox/17.0
Build ID: 20120822094317

Steps to reproduce:

Start Firefox


Actual results:

Address bas is not selected (no cursor).
Happens with about:blank and about:newtab.


Expected results:

The address bar should be selected by default.
Comment 1 Octoploid 2012-08-22 02:26:16 PDT
Started with:

commit 5f387a38960ae207462848cf0f2bbf20775abfa5
Author: Dão Gottwald <dao@mozilla.com>
Date:   Tue Aug 21 15:53:39 2012 +0200

    Bug 783103 - Avoid layout flush from isElementVisible when attempting to focus the URL bar or search bar. r=enn
Comment 2 Dão Gottwald [:dao] 2012-08-22 05:25:19 PDT
Created attachment 654180 [details] [diff] [review]
patch

I couldn't reproduce this bug with my default profiles on Windows and Linux, but I can reproduce it with a new profile on Linux. delayedStartup appears to be racing with the initial window being focused, and gURLBar.focused will only be true once the window is focused.
Comment 3 Neil Deakin 2012-08-22 06:44:48 PDT
Comment on attachment 654180 [details] [diff] [review]
patch

Seems ok, as long as the extra call to mouseoverToggle and select() is acceptable.
Comment 4 Dão Gottwald [:dao] 2012-08-22 07:01:22 PDT
(In reply to Neil Deakin from comment #3)
> Comment on attachment 654180 [details] [diff] [review]
> patch
> 
> Seems ok, as long as the extra call to mouseoverToggle and select() is
> acceptable.

FullScreen.mouseoverToggle will only be called when starting up in fullscreen mode, and return early because the fullscreen UI isn't set up at that point. select() can be avoided if deemed worthwhile, see bug 783064 comment 1.
Comment 6 Ed Morley [:emorley] 2012-08-23 03:51:19 PDT
https://hg.mozilla.org/mozilla-central/rev/3ded80c6a2da

Note You need to log in before you can comment on or make changes to this bug.