783134 - Crash on startup [@ nsWebShellWindow::WindowResized]

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

nsCOMPtr<nsIBaseWindow> shellAsWin(do_QueryInterface(mDocShell));
  shellAsWin->SetPositionAndSize(0, 0, aWidth, aHeight, false);

|mDocShell| is null here.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Work around crashing on startup with fullscreen widgets

I think what's unique about b2g here is that our xul:window starts up fullscreen, so we resize several times *very* early in startup.  This patch seems innocuous although it makes me sad.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 652286 [details] [diff] [review]
Work around crashing on startup with fullscreen widgets

Review of attachment 652286 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpfe/appshell/src/nsWebShellWindow.cpp
@@ +252,5 @@
>    }
>  
>    nsCOMPtr<nsIBaseWindow> shellAsWin(do_QueryInterface(mDocShell));
> +  if (shellAsWin)
> +    shellAsWin->SetPositionAndSize(0, 0, aWidth, aHeight, false);

{}

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d60761f2ce89

Neil, had to push this as an emergency fix; let me know if this isn't correct.

Comment 4

[Neil Deakin]

Yes, that should be ok. The old code had a null check on the docshell instead. You might want to check that and bail out at the beginning of the WindowResized instead and avoid the no-op call to AdjustPopupsOnWindowChange though but no big deal.

Comment 6

[Gene Lian (I already quit Mozilla)]

After including both the patches of bug 783134 and bug 783139, we can now avoid the crash and enter the home screen. However, the home button still don't work when we attempt to go back to the home screen from an app.

Comment 7

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Gene Lian [:gene] from comment #6)
> After including both the patches of bug 783134 and bug 783139, we can now
> avoid the crash and enter the home screen. However, the home button still
> don't work when we attempt to go back to the home screen from an app.

That is probably not related because revert the patch doesn't fix the home button.

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Yes, in my build from when this landed, the home button works fine.  Probably a gaia regression.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d60761f2ce89