783185 - CRL update timer doesn't work well

Status: RESOLVED INCOMPLETE

(Core :: Security, defect)

Description

[Makoto Kato [:m_kato]]

http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsCRLManager.cpp?mark=226-236#226

226       if(NS_SUCCEEDED(ComputeNextAutoUpdateTime(crlData, timingTypePref, dayCnt, &updateTime))){
227         updateTimeStr.AssignWithConversion(updateTime);
228         pref->SetCharPref(updateTimePrefStr.get(),updateTimeStr.get());
229         //Now, check if this update time is already in the past. This would
230         //imply we have downloaded the same crl, or there is something wrong
231         //with the next update date. We will not reschedule this crl in this
232         //session anymore - or else, we land into a loop. It would anyway be
233         //imported once the browser is restarted.
234         if(LL_CMP(updateTime, > , PR_Now())){
235           toBeRescheduled = true;
236         }

updateTime is PRUnichar*, so this compare is invalid

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Makoto Kato [:m_kato]]

bsmith, could you review this?  or you don't have time to do it?

Comment 3

[Makoto Kato [:m_kato]]

Attachment: fix

Kai, could you review this since bsmith is no repsonse?

Current code uses "int64_t(PRUnichar*) > int64_t(PR_Now)".  This condition is invalid.

Comment 4

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

CRL manager was removed.