Closed Bug 783185 Opened 9 years ago Closed 8 years ago

CRL update timer doesn't work well

Categories

(Core :: Security, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file, 1 obsolete file)

http://mxr.mozilla.org/mozilla-central/source/security/manager/ssl/src/nsCRLManager.cpp?mark=226-236#226

226       if(NS_SUCCEEDED(ComputeNextAutoUpdateTime(crlData, timingTypePref, dayCnt, &updateTime))){
227         updateTimeStr.AssignWithConversion(updateTime);
228         pref->SetCharPref(updateTimePrefStr.get(),updateTimeStr.get());
229         //Now, check if this update time is already in the past. This would
230         //imply we have downloaded the same crl, or there is something wrong
231         //with the next update date. We will not reschedule this crl in this
232         //session anymore - or else, we land into a loop. It would anyway be
233         //imported once the browser is restarted.
234         if(LL_CMP(updateTime, > , PR_Now())){
235           toBeRescheduled = true;
236         }

updateTime is PRUnichar*, so this compare is invalid
Assignee: nobody → m_kato
Attached patch fix (obsolete) — Splinter Review
Attachment #652379 - Flags: review?(bsmith)
Blocks: 786542
bsmith, could you review this?  or you don't have time to do it?
Attached patch fixSplinter Review
Kai, could you review this since bsmith is no repsonse?

Current code uses "int64_t(PRUnichar*) > int64_t(PR_Now)".  This condition is invalid.
Attachment #652379 - Attachment is obsolete: true
Attachment #652379 - Flags: review?(bsmith)
Attachment #680962 - Flags: review?(kaie)
CRL manager was removed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Attachment #680962 - Flags: review?(kaie)
You need to log in before you can comment on or make changes to this bug.