Closed Bug 783241 Opened 10 years ago Closed 10 years ago

add extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png to


(Firefox :: Theme, defect)

Not set



Firefox 17
Tracking Status
firefox15 --- wontfix
firefox16 --- fixed


(Reporter: bhearsum, Assigned: bhearsum)




(1 file)

bug 753618 removed preview.png from the default theme from the package but didn't add it to This ends up showing up as a warning in our update verification tests, because it exists in an older firefox that has been updated to the latest beta, but not in the latest beta's installer.

Unless there's a reason we want this it to exist for updated users only, we should add it there.
Attachment #652418 - Flags: review?(ted.mielczarek)
Attachment #652418 - Flags: review?(bmcbride)
Attachment #652418 - Flags: review?(ted.mielczarek) → review+
Attachment #652418 - Flags: review?(bmcbride) → review+
Comment on attachment 652418 [details] [diff] [review]
add preview.png to

I'd like to land this on Aurora and Beta. This patch will cause updates to 15 to remove extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png at update time, which will make them consistent with the Firefox 15.0 installer. I don't think there's any risk to us taking this.
Attachment #652418 - Flags: approval-mozilla-beta?
Attachment #652418 - Flags: approval-mozilla-aurora?
Comment on attachment 652418 [details] [diff] [review]
add preview.png to

Landed on m-c:
Attachment #652418 - Flags: checkin+
Comment on attachment 652418 [details] [diff] [review]
add preview.png to

Looks like a simple clean up, thanks for doing this. Approving for Aurora, but not Beta since we're too close to the end of cycle there.
Attachment #652418 - Flags: approval-mozilla-beta?
Attachment #652418 - Flags: approval-mozilla-beta-
Attachment #652418 - Flags: approval-mozilla-aurora?
Attachment #652418 - Flags: approval-mozilla-aurora+
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → bhearsum
Depends on: 753618
Flags: in-testsuite-
Target Milestone: --- → Firefox 17
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.