add extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png to removed-files.in

RESOLVED FIXED in Firefox 16

Status

()

Firefox
Theme
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Trunk
Firefox 17
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox15 wontfix, firefox16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 652418 [details] [diff] [review]
add preview.png to removed-files.in

bug 753618 removed preview.png from the default theme from the package but didn't add it to removed-files.in. This ends up showing up as a warning in our update verification tests, because it exists in an older firefox that has been updated to the latest beta, but not in the latest beta's installer.

Unless there's a reason we want this it to exist for updated users only, we should add it there.
Attachment #652418 - Flags: review?(ted.mielczarek)
Attachment #652418 - Flags: review?(bmcbride)
Attachment #652418 - Flags: review?(ted.mielczarek) → review+
Attachment #652418 - Flags: review?(bmcbride) → review+
(Assignee)

Comment 1

5 years ago
Comment on attachment 652418 [details] [diff] [review]
add preview.png to removed-files.in

I'd like to land this on Aurora and Beta. This patch will cause updates to 15 to remove extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png at update time, which will make them consistent with the Firefox 15.0 installer. I don't think there's any risk to us taking this.
Attachment #652418 - Flags: approval-mozilla-beta?
Attachment #652418 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 2

5 years ago
Comment on attachment 652418 [details] [diff] [review]
add preview.png to removed-files.in

Landed on m-c: https://hg.mozilla.org/mozilla-central/rev/ea85bbaa681e
Attachment #652418 - Flags: checkin+
Comment on attachment 652418 [details] [diff] [review]
add preview.png to removed-files.in

Looks like a simple clean up, thanks for doing this. Approving for Aurora, but not Beta since we're too close to the end of cycle there.
Attachment #652418 - Flags: approval-mozilla-beta?
Attachment #652418 - Flags: approval-mozilla-beta-
Attachment #652418 - Flags: approval-mozilla-aurora?
Attachment #652418 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/856b6b5bf31c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → bhearsum
status-firefox15: --- → wontfix
status-firefox16: --- → fixed
Depends on: 753618
Flags: in-testsuite-
Target Milestone: --- → Firefox 17
Version: unspecified → Trunk
Blocks: 783522
You need to log in before you can comment on or make changes to this bug.