783241 - add extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png to removed-files.in

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[[e-mail] (:bhearsum)]

Attachment: add preview.png to removed-files.in

bug 753618 removed preview.png from the default theme from the package but didn't add it to removed-files.in. This ends up showing up as a warning in our update verification tests, because it exists in an older firefox that has been updated to the latest beta, but not in the latest beta's installer.

Unless there's a reason we want this it to exist for updated users only, we should add it there.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 652418 [details] [diff] [review]
add preview.png to removed-files.in

I'd like to land this on Aurora and Beta. This patch will cause updates to 15 to remove extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png at update time, which will make them consistent with the Firefox 15.0 installer. I don't think there's any risk to us taking this.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 652418 [details] [diff] [review]
add preview.png to removed-files.in

Landed on m-c: https://hg.mozilla.org/mozilla-central/rev/ea85bbaa681e

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 652418 [details] [diff] [review]
add preview.png to removed-files.in

Looks like a simple clean up, thanks for doing this. Approving for Aurora, but not Beta since we're too close to the end of cycle there.

Comment 4

[[e-mail] (:bhearsum)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/856b6b5bf31c