783247 - Naming of Folders for new Bookmarks gets cut-off abruptly with Sync on.

Status: RESOLVED DUPLICATE of bug 697649

(Firefox :: Bookmarks & History, defect)

Description

[Mordecai]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120713134347

Steps to reproduce:

I activated Firefox Sync for the first time today.  After successfully setting it up I was browsing and trying to bookmark a page *and* create a new folder for that bookmark, as well. 


Actual results:

Upon clicking the "New Folder" button when saving the bookmark the user is given only a second or two to name the folder, before it is abruptly cut off and the resulting folder mislabeled.


Expected results:

Renaming the folder should not have a time limit imposed on it, and if it does, that time limit should be at least 30 seconds to a minute.  Firefox Sync has been determined to be the cause of the problem, because if it is disabled, this issue no longer arises.  I have confirmed this to effect 2 installations of firefox that are linked via Firefox Sync.  One is a desktop running Windows 7 64-bit, the other a laptop running Windows 7 32-bit.  Both are using the newest Firefox (14.0.1) and exhibit this same error.   

Users on the Firefox support forum report the issue as well, here: https://support.mozilla.org/en-US/questions/922693

Comment 1

[Matthias Versen [:Matti]]

trying bookmarks, could be also Mozilla services:sync..

Comment 2

[Marco Bonardo [:mak]]

I suspect Sync does sync the bookmarks and that causes a batch, and the batch causes the view to refresh, thus replacing the tree while you are editing the name.
We should probably somehow "lock" the treeview while it's being edited.

Comment 3

[Richard Newman [:rnewman]]

Batches cause UI redisplay!? Well, well. We always assumed it was just us spinning the event loop in an observer.

Comment 4

[Marco Bonardo [:mak]]

(In reply to Richard Newman [:rnewman] from comment #3)
> Batches cause UI redisplay!? Well, well. We always assumed it was just us
> spinning the event loop in an observer.

I just guessed, but actually looks like it doesn't happen for folder queries http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsNavHistoryResult.cpp#3532 and in this dialog we use allBookmarksFolderId.
So my guess was wrong and yours is likely true.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Marco Bonardo [:mak] from comment #4)
> (In reply to Richard Newman [:rnewman] from comment #3)
> > Batches cause UI redisplay!? Well, well. We always assumed it was just us
> > spinning the event loop in an observer.
> 
> I just guessed, but actually looks like it doesn't happen for folder queries
> http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/
> nsNavHistoryResult.cpp#3532 and in this dialog we use allBookmarksFolderId.
> So my guess was wrong and yours is likely true.

Well, drat. I was hoping that the easiest-to-fix guess was right :D

At some point I might still try removing Sync's batching calls, see if anything changes.