Change mobile-specific Google search URL to standard Google search URL

VERIFIED FIXED in Firefox 15

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
10 months ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 17
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 verified, firefox16 verified, firefox17 verified, firefox18 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 652558 [details] [diff] [review]
Use standard Google search URL

Google's recent UA changes have made forcing the mobile-specific search unnecessary. We should be able to use the standard query URL.
Attachment #652558 - Flags: review?(mark.finkle)
(Assignee)

Updated

5 years ago
Blocks: 776007
Comment on attachment 652558 [details] [diff] [review]
Use standard Google search URL

UX might want this uplifted as far as reasonable
Attachment #652558 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 2

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/83f6e76262be
(Assignee)

Comment 3

5 years ago
Comment on attachment 652558 [details] [diff] [review]
Use standard Google search URL

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Google mobile search is forced, meaning Request Desktop site option won't be honored for searches
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): medium-low risk - everything should be fine on our end, but there's always a chance Google could change something to break it again
String or UUID changes made by this patch: none
Attachment #652558 - Flags: approval-mozilla-beta?
Attachment #652558 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

5 years ago
status-firefox15: --- → affected
status-firefox16: --- → affected
Comment on attachment 652558 [details] [diff] [review]
Use standard Google search URL

Approving, if there are changes on google's end we'll have to do outreach but changing our code here makes sense for uplift.
Attachment #652558 - Flags: approval-mozilla-beta?
Attachment #652558 - Flags: approval-mozilla-beta+
Attachment #652558 - Flags: approval-mozilla-aurora?
Attachment #652558 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/83f6e76262be
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/releases/mozilla-beta/rev/1b1c3270c679
status-firefox15: affected → fixed
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/bbdbc7a0c457
status-firefox16: affected → fixed

Comment 8

5 years ago
What testing did this change get outside the US? There's at least bug 757979 that deals with the difference in experience in Japan for the previous iteration.
(Assignee)

Comment 9

5 years ago
(In reply to Axel Hecht [:Pike] from comment #8)
> What testing did this change get outside the US? There's at least bug 757979
> that deals with the difference in experience in Japan for the previous
> iteration.

The search engine XML files are localization-dependent; this patch is only for /mobile/locales/en-US/searchplugins/google.xml.
(Assignee)

Comment 10

5 years ago
(In reply to Brian Nicholson (:bnicholson) from comment #9)
> The search engine XML files are localization-dependent; this patch is only
> for /mobile/locales/en-US/searchplugins/google.xml.

After reading bug 757979, it looks like Japan (and other locales) were just using the English google.xml. https://bugzilla.mozilla.org/show_bug.cgi?id=757979#c25 sounds like the current implementation will be changed to use a single XML for all localizations, but that doesn't appear to be implemented yet.

I assumed different locales would just have their own XML files, meaning this change wouldn't affect them, but that doesn't appear to be the case. AFAIK, there wasn't any testing done for other languages for this patch.

Updated

5 years ago
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: fixed → verified
status-firefox17: --- → verified
status-firefox18: --- → verified
Duplicate of this bug: 776007
You need to log in before you can comment on or make changes to this bug.