Last Comment Bug 783379 - Image discarding not always working correctly on OSX and Linux
: Image discarding not always working correctly on OSX and Linux
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla17
Assigned To: Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13)
:
Mentors:
: 783126 783355 784068 (view as bug list)
Depends on:
Blocks: 683290
  Show dependency treegraph
 
Reported: 2012-08-16 14:20 PDT by Andrew McCreight [:mccr8]
Modified: 2012-08-21 15:21 PDT (History)
11 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
-


Attachments
Patch (3.96 KB, patch)
2012-08-20 17:07 PDT, Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13)
roc: review+
Details | Diff | Review

Description Andrew McCreight [:mccr8] 2012-08-16 14:20:06 PDT
I've only noticed this recently, in the last few days.  It maybe due to bug 683290.

When you have Zimbra in a background tab for a while, then switch back, many of the images don't show up.  The regular folder icon on the left side shows up, but the icons for "sent" "drafts" "junk", and the various icons on the main toolbar across the middle (new, get mail, delete, etc.) don't show up. Interacting with the page a little brings it back to some extent.
Comment 1 Andrew McCreight [:mccr8] 2012-08-16 14:25:04 PDT
Okay, it does show the icon for "sent", "new" and "translate".
Comment 2 Andrew McCreight [:mccr8] 2012-08-16 15:09:26 PDT
Similar problem on Pandora. There's a cloud image in the background that isn't displayed if you flip to another tab for a while, then switch back.
Comment 3 Andrew McCreight [:mccr8] 2012-08-16 15:09:57 PDT
On Pandora, image is reshown when you scroll up and down.
Comment 4 Andrew McCreight [:mccr8] 2012-08-18 11:42:21 PDT
When I load dslreports.com, the images for the main toolbar (home, reviews, tools, forums, etc.) are not immediately displayed.  Switching to another tab and back does show them, as does reloading.  Doing a hard reload (command-shift-R on OSX) and they disappear again until I switch to another tab.

Also, I tried an 8/14 nightly at Kyle's request, and it did not show the symptoms in Comment 0-2.
Comment 5 Andrew McCreight [:mccr8] 2012-08-20 08:20:19 PDT
https://odesk.com/ doesn't show the background image (a bunch of people) on initial load.
Comment 6 Alon Zakai (:azakai) 2012-08-20 10:02:11 PDT
I and brson are seeing this on Linux as well. Started over the last few days.
Comment 7 Andrew McCreight [:mccr8] 2012-08-20 10:14:17 PDT
odesk.com is working for me now, so maybe it was just site slowness.
Comment 8 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2012-08-20 10:36:52 PDT
*** Bug 784068 has been marked as a duplicate of this bug. ***
Comment 9 Andrew McCreight [:mccr8] 2012-08-20 10:40:51 PDT
Alice's regression range in bug 784068 points at khuey's patch.
Comment 10 Alon Zakai (:azakai) 2012-08-20 11:29:34 PDT
(In reply to Andrew McCreight [:mccr8] from comment #7)
> odesk.com is working for me now, so maybe it was just site slowness.

Still present for me in zimbra.
Comment 11 Alon Zakai (:azakai) 2012-08-20 13:53:51 PDT
Bisecting the range from dupe bug 784068 comment 5, the first bad revision is

102329:5c730c1f2274

changeset:   102329:5c730c1f2274
user:        Kyle Huey <khuey@kylehuey.com>
date:        Mon Aug 13 15:04:19 2012 -0700
summary:     Bug 697230: Part 1 - Centralize style image observers. r=bz

(Same as causes the permaorange in bug 651866.)

Bisecting methodology: Open zimbra, browse to another tab, wait 1.5 minutes, go back. In the bad case most of the images vanished and only reappear on clicking on the page.
Comment 12 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2012-08-20 17:07:14 PDT
Created attachment 653585 [details] [diff] [review]
Patch

There is an optimization to avoid invalidating frames before the first paint (since there is no existing data that is now invalid).  The way we listen for paints is flawed, and sometimes we don't realize that a paint has occurred and fail to invalidate when we should.  roc thinks this optimization is probably unnecessary, since invalidating these frames should be cheap.  This patch removes that optimization.
Comment 13 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2012-08-20 17:15:56 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/657b3f3a616b
Comment 14 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-08-20 17:48:58 PDT
*** Bug 783355 has been marked as a duplicate of this bug. ***
Comment 15 Ed Morley [:emorley] 2012-08-21 06:29:41 PDT
https://hg.mozilla.org/mozilla-central/rev/657b3f3a616b
Comment 16 Alice0775 White 2012-08-21 09:59:23 PDT
*** Bug 784068 has been marked as a duplicate of this bug. ***
Comment 17 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2012-08-21 11:37:43 PDT
*** Bug 783126 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.