783424 - recommend panel should be populated as popup is showing

Status: RESOLVED WONTFIX

(Firefox Graveyard :: SocialAPI, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

As discussed with Jaws on IRC, the population of the "share panel" should be deferred until the panel is actually needed, to avoid taking a post-startup hit for a panel that may never actually be displayed.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Populate the panel in onpopupshowing

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 652630 [details] [diff] [review]
Populate the panel in onpopupshowing

Review of attachment 652630 [details] [diff] [review]:
-----------------------------------------------------------------

The browser-social.js and browser.xul changes seem fine to me, but we don't need to make those changes to browser_social_shareButton.js since they aren't affecting the dynamic values of the popup.

Did you have test failures without the changes to browser_social_shareButton.js? The test is going to be disabled as part of bug 777176 since it isn't properly cleaning up after itself (reenabling it is part of bug 780010).

Comment 3

[Mark Hammond [:markh] [:mhammond]]

(In reply to Jared Wein [:jaws] from comment #2)
> Did you have test failures without the changes to
> browser_social_shareButton.js? The test is going to be disabled as part of
> bug 777176 since it isn't properly cleaning up after itself (reenabling it
> is part of bug 780010).

I did have test failures - the test was opening the panel before the provider had responded with the profile info, hence the popup's header was blank.  This is probably masking a different bug - that the share button shouldn't actually be enabled at all when no profile info is available (or if it is enabled, it should display some UI indicating a login is necessary or something)

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, hence the reasoning for disabling it in bug 777176. I just landed the patch for bug 777176 on mozilla-inbound.

Comment 5

[Shane Caraveo (:mixedpuppy)]

this may be obsoleted by bug 818675, but IMO there is still a use-case for one-click recomment.

Comment 6

[Shane Caraveo (:mixedpuppy)]

obsoleting bug, replacement in bug 853151 is merely a two-state button.