recommend panel should be populated as popup is showing

RESOLVED WONTFIX

Status

()

Firefox
SocialAPI
RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: markh, Assigned: markh)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As discussed with Jaws on IRC, the population of the "share panel" should be deferred until the panel is actually needed, to avoid taking a post-startup hit for a panel that may never actually be displayed.
(Assignee)

Comment 1

5 years ago
Created attachment 652630 [details] [diff] [review]
Populate the panel in onpopupshowing
Assignee: nobody → mhammond
Status: NEW → ASSIGNED
Attachment #652630 - Flags: review?(jaws)
Comment on attachment 652630 [details] [diff] [review]
Populate the panel in onpopupshowing

Review of attachment 652630 [details] [diff] [review]:
-----------------------------------------------------------------

The browser-social.js and browser.xul changes seem fine to me, but we don't need to make those changes to browser_social_shareButton.js since they aren't affecting the dynamic values of the popup.

Did you have test failures without the changes to browser_social_shareButton.js? The test is going to be disabled as part of bug 777176 since it isn't properly cleaning up after itself (reenabling it is part of bug 780010).
Attachment #652630 - Flags: review?(jaws) → feedback+
(Assignee)

Comment 3

5 years ago
(In reply to Jared Wein [:jaws] from comment #2)
> Did you have test failures without the changes to
> browser_social_shareButton.js? The test is going to be disabled as part of
> bug 777176 since it isn't properly cleaning up after itself (reenabling it
> is part of bug 780010).

I did have test failures - the test was opening the panel before the provider had responded with the profile info, hence the popup's header was blank.  This is probably masking a different bug - that the share button shouldn't actually be enabled at all when no profile info is available (or if it is enabled, it should display some UI indicating a login is necessary or something)
Yeah, hence the reasoning for disabling it in bug 777176. I just landed the patch for bug 777176 on mozilla-inbound.
Depends on: 818675
this may be obsoleted by bug 818675, but IMO there is still a use-case for one-click recomment.
Summary: share panel should be populated as popup is showing → recommend panel should be populated as popup is showing
obsoleting bug, replacement in bug 853151 is merely a two-state button.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.