783457 - about:support uses hostname instead of realhostname

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Joshua Cranmer [:jcranmer]]

I've always hated the names of these two attributes, since it means people are probably going to be very apt to pick the wrong one.

Comment 1

[:aceman]

Looks like this line should be changed:
http://hg.mozilla.org/comm-central/file/3b75111da3ba/mail/components/about-support/aboutSupport.js#l83

Comment 2

[:aceman]

Attachment: patch

It works for me on Linux.

Comment 3

[:aceman]

While testing it out I noticed my IM account (of type "JS test") shows garbage as:
(im) realHostName FIXME:0

Probably realHostName is unimplemented. Also the port is shown as 0. The about:support generator hides the port only when it is set to -1. That is used in Local Folders and Feeds account types.
Florian, please look at it if this isn't a problem in more IM protocols (or just in JS test).

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 652772 [details] [diff] [review]
patch

I'm not a peer of the FE stuff, so redirecting to mconley. That said, this looks good to me...

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 652772 [details] [diff] [review]
patch

Review of attachment 652772 [details] [diff] [review]:
-----------------------------------------------------------------

It's kind of a tragedy that we have "hostName" and "realHostName". Puts a bad taste in my mouth.

Anyhow, I haven't tested this, but I trust you have, and it looks like it's doing the right thing.

Comment 6

[:aceman]

I have tested the appearance on Linux and it works (changes the shown server host) and also changes the host in the IM account to the placeholder string. So it does something :)

Comment 7

[Florian Quèze [:florian]]

(In reply to :aceman from comment #3)
> While testing it out I noticed my IM account (of type "JS test") shows
> garbage as:
> (im) realHostName FIXME:0
> 
> Probably realHostName is unimplemented. Also the port is shown as 0. The
> about:support generator hides the port only when it is set to -1. That is
> used in Local Folders and Feeds account types.
> Florian, please look at it if this isn't a problem in more IM protocols (or
> just in JS test).

It's not specific to any IM protocol (so no, this isn't just for JS test); this value is from imIncomingServer at http://mxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#57

I couldn't find any use case for these 2 values at the time I wrote this code.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/8261f4f34dca

Comment 9

[:aceman]

So it seems now there is a use case and the comment in the code is no longer valid. The values are exposed now.