Last Comment Bug 783457 - about:support uses hostname instead of realhostname
: about:support uses hostname instead of realhostname
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 17.0
Assigned To: :aceman
:
:
Mentors:
Depends on: 791542
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-16 20:57 PDT by Joshua Cranmer [:jcranmer]
Modified: 2012-09-17 06:39 PDT (History)
6 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1.11 KB, patch)
2012-08-17 08:13 PDT, :aceman
mconley: review+
Details | Diff | Splinter Review

Description Joshua Cranmer [:jcranmer] 2012-08-16 20:57:41 PDT
I've always hated the names of these two attributes, since it means people are probably going to be very apt to pick the wrong one.
Comment 2 :aceman 2012-08-17 08:13:58 PDT
Created attachment 652772 [details] [diff] [review]
patch

It works for me on Linux.
Comment 3 :aceman 2012-08-17 08:18:17 PDT
While testing it out I noticed my IM account (of type "JS test") shows garbage as:
(im) realHostName FIXME:0

Probably realHostName is unimplemented. Also the port is shown as 0. The about:support generator hides the port only when it is set to -1. That is used in Local Folders and Feeds account types.
Florian, please look at it if this isn't a problem in more IM protocols (or just in JS test).
Comment 4 Joshua Cranmer [:jcranmer] 2012-08-17 08:25:10 PDT
Comment on attachment 652772 [details] [diff] [review]
patch

I'm not a peer of the FE stuff, so redirecting to mconley. That said, this looks good to me...
Comment 5 Mike Conley (:mconley) 2012-08-17 08:40:35 PDT
Comment on attachment 652772 [details] [diff] [review]
patch

Review of attachment 652772 [details] [diff] [review]:
-----------------------------------------------------------------

It's kind of a tragedy that we have "hostName" and "realHostName". Puts a bad taste in my mouth.

Anyhow, I haven't tested this, but I trust you have, and it looks like it's doing the right thing.
Comment 6 :aceman 2012-08-17 08:45:32 PDT
I have tested the appearance on Linux and it works (changes the shown server host) and also changes the host in the IM account to the placeholder string. So it does something :)
Comment 7 Florian Quèze [:florian] [:flo] 2012-08-17 13:14:32 PDT
(In reply to :aceman from comment #3)
> While testing it out I noticed my IM account (of type "JS test") shows
> garbage as:
> (im) realHostName FIXME:0
> 
> Probably realHostName is unimplemented. Also the port is shown as 0. The
> about:support generator hides the port only when it is set to -1. That is
> used in Local Folders and Feeds account types.
> Florian, please look at it if this isn't a problem in more IM protocols (or
> just in JS test).

It's not specific to any IM protocol (so no, this isn't just for JS test); this value is from imIncomingServer at http://mxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#57

I couldn't find any use case for these 2 values at the time I wrote this code.
Comment 8 Ryan VanderMeulen [:RyanVM] 2012-08-17 17:38:55 PDT
https://hg.mozilla.org/comm-central/rev/8261f4f34dca
Comment 9 :aceman 2012-08-25 06:33:42 PDT
So it seems now there is a use case and the comment in the code is no longer valid. The values are exposed now.

Note You need to log in before you can comment on or make changes to this bug.