about:support uses hostname instead of realhostname

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jcranmer, Assigned: aceman)

Tracking

Trunk
Thunderbird 17.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
I've always hated the names of these two attributes, since it means people are probably going to be very apt to pick the wrong one.
(Assignee)

Comment 1

5 years ago
Looks like this line should be changed:
http://hg.mozilla.org/comm-central/file/3b75111da3ba/mail/components/about-support/aboutSupport.js#l83
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 2

5 years ago
Created attachment 652772 [details] [diff] [review]
patch

It works for me on Linux.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #652772 - Flags: review?(Pidgeot18)
(Assignee)

Comment 3

5 years ago
While testing it out I noticed my IM account (of type "JS test") shows garbage as:
(im) realHostName FIXME:0

Probably realHostName is unimplemented. Also the port is shown as 0. The about:support generator hides the port only when it is set to -1. That is used in Local Folders and Feeds account types.
Florian, please look at it if this isn't a problem in more IM protocols (or just in JS test).
Version: unspecified → Trunk
(Reporter)

Comment 4

5 years ago
Comment on attachment 652772 [details] [diff] [review]
patch

I'm not a peer of the FE stuff, so redirecting to mconley. That said, this looks good to me...
Attachment #652772 - Flags: review?(Pidgeot18) → review?(mconley)
Comment on attachment 652772 [details] [diff] [review]
patch

Review of attachment 652772 [details] [diff] [review]:
-----------------------------------------------------------------

It's kind of a tragedy that we have "hostName" and "realHostName". Puts a bad taste in my mouth.

Anyhow, I haven't tested this, but I trust you have, and it looks like it's doing the right thing.
Attachment #652772 - Flags: review?(mconley) → review+
(Assignee)

Comment 6

5 years ago
I have tested the appearance on Linux and it works (changes the shown server host) and also changes the host in the IM account to the placeholder string. So it does something :)
Keywords: checkin-needed
(In reply to :aceman from comment #3)
> While testing it out I noticed my IM account (of type "JS test") shows
> garbage as:
> (im) realHostName FIXME:0
> 
> Probably realHostName is unimplemented. Also the port is shown as 0. The
> about:support generator hides the port only when it is set to -1. That is
> used in Local Folders and Feeds account types.
> Florian, please look at it if this isn't a problem in more IM protocols (or
> just in JS test).

It's not specific to any IM protocol (so no, this isn't just for JS test); this value is from imIncomingServer at http://mxr.mozilla.org/comm-central/source/mail/components/im/imIncomingServer.js#57

I couldn't find any use case for these 2 values at the time I wrote this code.
https://hg.mozilla.org/comm-central/rev/8261f4f34dca
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
(Assignee)

Comment 9

5 years ago
So it seems now there is a use case and the comment in the code is no longer valid. The values are exposed now.
Depends on: 791542
You need to log in before you can comment on or make changes to this bug.